[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin

[GitBox <gi...@apache.org>]

dmsolr commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r368263056
 
 

 ##########
 File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/influxdb/base/InfluxStorageDAO.java
 ##########
 @@ -53,6 +53,6 @@ public IRecordDAO newRecordDao(StorageBuilder<Record> storageBuilder) {
 
     @Override
     public INoneStreamDAO newNoneStreamDao(StorageBuilder<NoneStream> storageBuilder) {
-        return new NoneStreamDAO();
+        return new NoneStreamDAO(influxClient, storageBuilder);
 
 Review comment:
   That sounds the relationship database better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services