You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "AchimGaedkeLynker (via GitHub)" <gi...@apache.org> on 2023/09/22 10:17:00 UTC
[GitHub] [airflow] AchimGaedkeLynker opened a new pull request, #34547: Update define-extra-link.rst
AchimGaedkeLynker opened a new pull request, #34547:
URL: https://github.com/apache/airflow/pull/34547
Add necessary imports for type hints in examples.
The examples look like they are intended to be self-contained and should work when cutting and pasting them into a (plugin) python file. Sadly the imports are incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update define-extra-link.rst [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #34547:
URL: https://github.com/apache/airflow/pull/34547#discussion_r1346451574
##########
docs/apache-airflow/howto/define-extra-link.rst:
##########
@@ -118,7 +120,9 @@ Console, but if we wanted to change that link we could:
.. code-block:: python
from airflow.plugins_manager import AirflowPlugin
- from airflow.models.baseoperator import BaseOperatorLink
+ from airflow.models.baseoperator import BaseOperatorLink, BaseOperator
+ from airflow.models.taskinstancekey import TaskInstanceKey
+
Review Comment:
```suggestion
from airflow.models.taskinstancekey import TaskInstanceKey
```
##########
docs/apache-airflow/howto/define-extra-link.rst:
##########
@@ -118,7 +120,9 @@ Console, but if we wanted to change that link we could:
.. code-block:: python
from airflow.plugins_manager import AirflowPlugin
- from airflow.models.baseoperator import BaseOperatorLink
+ from airflow.models.baseoperator import BaseOperatorLink, BaseOperator
+ from airflow.models.taskinstancekey import TaskInstanceKey
+
from airflow.models.xcom import XCom
Review Comment:
```suggestion
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.models.xcom import XCom
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update define-extra-link.rst [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #34547:
URL: https://github.com/apache/airflow/pull/34547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #34547: Update define-extra-link.rst
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34547:
URL: https://github.com/apache/airflow/pull/34547#issuecomment-1731172372
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update define-extra-link.rst [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #34547:
URL: https://github.com/apache/airflow/pull/34547#issuecomment-1747719981
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update define-extra-link.rst [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #34547:
URL: https://github.com/apache/airflow/pull/34547#discussion_r1346451378
##########
docs/apache-airflow/howto/define-extra-link.rst:
##########
@@ -29,6 +29,7 @@ The following code shows how to add extra links to an operator via Plugins:
from airflow.models.baseoperator import BaseOperator, BaseOperatorLink
from airflow.plugins_manager import AirflowPlugin
+ from airflow.models.taskinstancekey import TaskInstanceKey
Review Comment:
```suggestion
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.plugins_manager import AirflowPlugin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update define-extra-link.rst [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #34547:
URL: https://github.com/apache/airflow/pull/34547#discussion_r1346451574
##########
docs/apache-airflow/howto/define-extra-link.rst:
##########
@@ -118,7 +120,9 @@ Console, but if we wanted to change that link we could:
.. code-block:: python
from airflow.plugins_manager import AirflowPlugin
- from airflow.models.baseoperator import BaseOperatorLink
+ from airflow.models.baseoperator import BaseOperatorLink, BaseOperator
+ from airflow.models.taskinstancekey import TaskInstanceKey
+
Review Comment:
```suggestion
from airflow.models.taskinstancekey import TaskInstanceKey
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update define-extra-link.rst [airflow]
Posted by "AchimGaedkeLynker (via GitHub)" <gi...@apache.org>.
AchimGaedkeLynker commented on PR #34547:
URL: https://github.com/apache/airflow/pull/34547#issuecomment-1745858498
@eladkal - what else needs doing here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org