You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yangguangcai1 (via GitHub)" <gi...@apache.org> on 2023/08/31 05:00:24 UTC
[GitHub] [nuttx-apps] yangguangcai1 opened a new pull request, #2021: add test atomic
yangguangcai1 opened a new pull request, #2021:
URL: https://github.com/apache/nuttx-apps/pull/2021
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #2021: add test atomic
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2021:
URL: https://github.com/apache/nuttx-apps/pull/2021#discussion_r1313177616
##########
examples/atomic/Kconfig:
##########
@@ -0,0 +1,29 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config EXAMPLES_ATOMIC
+ tristate "\"Test atomic\" example"
Review Comment:
The code is a simple demo to check the atomic work as expect, so it's fine to put either examples or testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] yangguangcai1 commented on a diff in pull request #2021: add test atomic
Posted by "yangguangcai1 (via GitHub)" <gi...@apache.org>.
yangguangcai1 commented on code in PR #2021:
URL: https://github.com/apache/nuttx-apps/pull/2021#discussion_r1314699409
##########
examples/atomic/Kconfig:
##########
@@ -0,0 +1,29 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config EXAMPLES_ATOMIC
+ tristate "\"Test atomic\" example"
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #2021: add test atomic
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #2021:
URL: https://github.com/apache/nuttx-apps/pull/2021#discussion_r1312172524
##########
examples/atomic/Kconfig:
##########
@@ -0,0 +1,29 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config EXAMPLES_ATOMIC
+ tristate "\"Test atomic\" example"
Review Comment:
Why test atomic is part of "examples" and not "testing"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #2021: add test atomic
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2021:
URL: https://github.com/apache/nuttx-apps/pull/2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org