You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "John Siracusa (JIRA)" <ji...@apache.org> on 2011/03/03 17:06:37 UTC
[jira] Created: (THRIFT-1082) Thrift::FramedTransport sometimes
calls close() on an undefined value
Thrift::FramedTransport sometimes calls close() on an undefined value
---------------------------------------------------------------------
Key: THRIFT-1082
URL: https://issues.apache.org/jira/browse/THRIFT-1082
Project: Thrift
Issue Type: Bug
Components: Perl - Library
Environment: CentOS release 5.4 (x86_64), perl 5.8.8
Reporter: John Siracusa
The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
(in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
The patch below is a simple workaround to the problem.
--- lib/Thrift/FramedTransport.pm 2011-03-03 11:02:25.000000000 -0500
+++ lib/Thrift/FramedTransport.pm.orig 2011-03-03 11:02:00.000000000 -0500
@@ -68,7 +68,7 @@
{
my $self = shift;
- $self->{transport}->close() if (defined $self->{transport});
+ $self->{transport}->close();
}
#
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1082) Thrift::FramedTransport sometimes
calls close() on an undefined value
Posted by "John Siracusa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Siracusa updated THRIFT-1082:
----------------------------------
Description:
The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
(in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
The attached patch is a simple workaround to the problem.
was:
The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
(in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
The patch below is a simple workaround to the problem.
--- lib/Thrift/FramedTransport.pm 2011-03-03 11:02:25.000000000 -0500
+++ lib/Thrift/FramedTransport.pm.orig 2011-03-03 11:02:00.000000000 -0500
@@ -68,7 +68,7 @@
{
my $self = shift;
- $self->{transport}->close() if (defined $self->{transport});
+ $self->{transport}->close();
}
#
> Thrift::FramedTransport sometimes calls close() on an undefined value
> ---------------------------------------------------------------------
>
> Key: THRIFT-1082
> URL: https://issues.apache.org/jira/browse/THRIFT-1082
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: CentOS release 5.4 (x86_64), perl 5.8.8
> Reporter: John Siracusa
> Attachments: FramedTransport.patch
>
>
> The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
> (in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
> The attached patch is a simple workaround to the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1082) Thrift::FramedTransport sometimes
calls close() on an undefined value
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1082.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.9
Assignee: John Siracusa
Committed a modified version of this
> Thrift::FramedTransport sometimes calls close() on an undefined value
> ---------------------------------------------------------------------
>
> Key: THRIFT-1082
> URL: https://issues.apache.org/jira/browse/THRIFT-1082
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: CentOS release 5.4 (x86_64), perl 5.8.8
> Reporter: John Siracusa
> Assignee: John Siracusa
> Fix For: 0.9
>
> Attachments: FramedTransport.patch
>
>
> The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
> (in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
> The attached patch is a simple workaround to the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1082) Thrift::FramedTransport sometimes
calls close() on an undefined value
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465579#comment-13465579 ]
Hudson commented on THRIFT-1082:
--------------------------------
Integrated in Thrift #539 (See [https://builds.apache.org/job/Thrift/539/])
THRIFT-1082: Thrift::FramedTransport sometimes calls close() on an undefined value
Client: perl
Patch: John Siracusa
Fixes Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() (Revision 1391418)
Result = FAILURE
jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1391418
Files :
* /thrift/trunk/lib/perl/lib/Thrift/FramedTransport.pm
> Thrift::FramedTransport sometimes calls close() on an undefined value
> ---------------------------------------------------------------------
>
> Key: THRIFT-1082
> URL: https://issues.apache.org/jira/browse/THRIFT-1082
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: CentOS release 5.4 (x86_64), perl 5.8.8
> Reporter: John Siracusa
> Assignee: John Siracusa
> Fix For: 0.9
>
> Attachments: FramedTransport.patch
>
>
> The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
> (in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
> The attached patch is a simple workaround to the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (THRIFT-1082) Thrift::FramedTransport sometimes
calls close() on an undefined value
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002372#comment-13002372 ]
Bryan Duxbury commented on THRIFT-1082:
---------------------------------------
Is this patch reversed?
> Thrift::FramedTransport sometimes calls close() on an undefined value
> ---------------------------------------------------------------------
>
> Key: THRIFT-1082
> URL: https://issues.apache.org/jira/browse/THRIFT-1082
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: CentOS release 5.4 (x86_64), perl 5.8.8
> Reporter: John Siracusa
> Attachments: FramedTransport.patch
>
>
> The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
> (in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
> The attached patch is a simple workaround to the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (THRIFT-1082) Thrift::FramedTransport sometimes
calls close() on an undefined value
Posted by "John Siracusa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002379#comment-13002379 ]
John Siracusa commented on THRIFT-1082:
---------------------------------------
Whoops, yeah, sorry.
> Thrift::FramedTransport sometimes calls close() on an undefined value
> ---------------------------------------------------------------------
>
> Key: THRIFT-1082
> URL: https://issues.apache.org/jira/browse/THRIFT-1082
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: CentOS release 5.4 (x86_64), perl 5.8.8
> Reporter: John Siracusa
> Attachments: FramedTransport.patch
>
>
> The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
> (in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
> The attached patch is a simple workaround to the problem.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1082) Thrift::FramedTransport sometimes
calls close() on an undefined value
Posted by "John Siracusa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Siracusa updated THRIFT-1082:
----------------------------------
Attachment: FramedTransport.patch
> Thrift::FramedTransport sometimes calls close() on an undefined value
> ---------------------------------------------------------------------
>
> Key: THRIFT-1082
> URL: https://issues.apache.org/jira/browse/THRIFT-1082
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: CentOS release 5.4 (x86_64), perl 5.8.8
> Reporter: John Siracusa
> Attachments: FramedTransport.patch
>
>
> The Thrift::FramedTransport module sometimes ends up calling the close() method on an undefined value inside its own close() method during global destruction. Events during global destruction are unordered, so it's difficult to reproduce this bug, but it does happen, producing error messages like this:
> (in cleanup) Can't call method "close" on an undefined value at /usr/lib/perl5/vendor_perl/5.8.8/Thrift/FramedTransport.pm line 71 during global destruction.
> The patch below is a simple workaround to the problem.
> --- lib/Thrift/FramedTransport.pm 2011-03-03 11:02:25.000000000 -0500
> +++ lib/Thrift/FramedTransport.pm.orig 2011-03-03 11:02:00.000000000 -0500
> @@ -68,7 +68,7 @@
> {
> my $self = shift;
>
> - $self->{transport}->close() if (defined $self->{transport});
> + $self->{transport}->close();
> }
>
> #
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira