You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2010/04/21 20:53:50 UTC
[jira] Created: (WICKET-2844) Make CheckGroupSelector Ajax friendly
Make CheckGroupSelector Ajax friendly
-------------------------------------
Key: WICKET-2844
URL: https://issues.apache.org/jira/browse/WICKET-2844
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.7
Reporter: Martin Grigorov
org.apache.wicket.markup.html.form.CheckGroupSelector changes the 'checked' property of the controlled checkboxes. The following patch modifies it to use .click() to change the state so this way if there is AjaxFormChoiceComponentUpdatingBehavior added to the CheckGroup it will fire for all checkboxes which state is changed.
- "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { cb[i].checked=this.checked; } } else { cb.checked=this.checked; } }");
+ "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { if (cb[i].checked != this.checked) {cb[i].click();} } } else { cb.checked=this.checked; } }");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2844) Make CheckGroupSelector Ajax
friendly
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-2844.
-------------------------------------
Fix Version/s: 1.4.10
1.5-M1
Resolution: Fixed
Fixed with r979800 in trunk and r979801 in 1.4.x
> Make CheckGroupSelector Ajax friendly
> -------------------------------------
>
> Key: WICKET-2844
> URL: https://issues.apache.org/jira/browse/WICKET-2844
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.7
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Fix For: 1.4.10, 1.5-M1
>
>
> org.apache.wicket.markup.html.form.CheckGroupSelector changes the 'checked' property of the controlled checkboxes. The following patch modifies it to use .click() to change the state so this way if there is AjaxFormChoiceComponentUpdatingBehavior added to the CheckGroup it will fire for all checkboxes which state is changed.
> - "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { cb[i].checked=this.checked; } } else { cb.checked=this.checked; } }");
> + "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { if (cb[i].checked != this.checked) {cb[i].click();} } } else { cb.checked=this.checked; } }");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2844) Make CheckGroupSelector Ajax
friendly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892997#action_12892997 ]
Hudson commented on WICKET-2844:
--------------------------------
Integrated in Apache Wicket 1.5.x #177 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.5.x/177/])
> Make CheckGroupSelector Ajax friendly
> -------------------------------------
>
> Key: WICKET-2844
> URL: https://issues.apache.org/jira/browse/WICKET-2844
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.7
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Fix For: 1.4.10, 1.5-M1
>
>
> org.apache.wicket.markup.html.form.CheckGroupSelector changes the 'checked' property of the controlled checkboxes. The following patch modifies it to use .click() to change the state so this way if there is AjaxFormChoiceComponentUpdatingBehavior added to the CheckGroup it will fire for all checkboxes which state is changed.
> - "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { cb[i].checked=this.checked; } } else { cb.checked=this.checked; } }");
> + "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { if (cb[i].checked != this.checked) {cb[i].click();} } } else { cb.checked=this.checked; } }");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-2844) Make CheckGroupSelector Ajax
friendly
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-2844:
---------------------------------------
Assignee: Martin Grigorov
> Make CheckGroupSelector Ajax friendly
> -------------------------------------
>
> Key: WICKET-2844
> URL: https://issues.apache.org/jira/browse/WICKET-2844
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.7
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
>
> org.apache.wicket.markup.html.form.CheckGroupSelector changes the 'checked' property of the controlled checkboxes. The following patch modifies it to use .click() to change the state so this way if there is AjaxFormChoiceComponentUpdatingBehavior added to the CheckGroup it will fire for all checkboxes which state is changed.
> - "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { cb[i].checked=this.checked; } } else { cb.checked=this.checked; } }");
> + "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { if (cb[i].checked != this.checked) {cb[i].click();} } } else { cb.checked=this.checked; } }");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2844) Make CheckGroupSelector Ajax
friendly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892898#action_12892898 ]
Hudson commented on WICKET-2844:
--------------------------------
Integrated in Apache Wicket 1.4.x #64 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.4.x/64/])
WICKET-2844 Make CheckGroupSelector Ajax friendly
Use checkbox.click() instead of checkbox.checked=bool.
#click() will trigger any registered event listeners (e.g. registered by AjaxFormChoiceComponentUpdatingBehavior)
port r979800 from trunk
> Make CheckGroupSelector Ajax friendly
> -------------------------------------
>
> Key: WICKET-2844
> URL: https://issues.apache.org/jira/browse/WICKET-2844
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.7
> Reporter: Martin Grigorov
> Assignee: Martin Grigorov
> Fix For: 1.4.10, 1.5-M1
>
>
> org.apache.wicket.markup.html.form.CheckGroupSelector changes the 'checked' property of the controlled checkboxes. The following patch modifies it to use .click() to change the state so this way if there is AjaxFormChoiceComponentUpdatingBehavior added to the CheckGroup it will fire for all checkboxes which state is changed.
> - "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { cb[i].checked=this.checked; } } else { cb.checked=this.checked; } }");
> + "']; if (cb!=null) { if (!isNaN(cb.length)) { for(var i=0;i<cb.length;i++) { if (cb[i].checked != this.checked) {cb[i].click();} } } else { cb.checked=this.checked; } }");
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.