[jira] [Commented] (SOLR-12377) Overseer leak failure in TestLeaderElectionZkExpiry

["Erick Erickson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481703#comment-16481703 ] 

Erick Erickson commented on SOLR-12377:
---------------------------------------

Please feel totally free to remove any BadApple annotation you even _think_ is unnecessary because of work you've done fixing something similar. It can always go back later.

Another approach is to comment out the annotation (optionally with a date) when at all unsure, but that's not a requirement, there's always the Git record.

> Overseer leak failure in TestLeaderElectionZkExpiry 
> ----------------------------------------------------
>
>                 Key: SOLR-12377
>                 URL: https://issues.apache.org/jira/browse/SOLR-12377
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Major
>         Attachments: SOLR-12377.patch, TestLeaderElectionZkExpiry-Overseer-leak.log
>
>
> After the SOLR-12200 is done, I checked {{TestLeaderElectionZkExpiry}} which is bad apple now. it yields the same Overseer leakage failure. Attaching a simple fix after which it beasts fine.
> {code}
> $ ant beast -Dbeast.iters=100 -Dtestcase=TestLeaderElectionZkExpiry -Dtests.dups=3
> ...
>   [beaster] Beast round: 100
>   ..
>   [beaster] Beasting finished.
> -check-totals:
> beast:
> BUILD SUCCESSFUL
> {code} 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org