You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:08:49 UTC
[GitHub] [incubator-tvm] mei-ye opened a new pull request #5659: [TARGET] enable amd_apu device on vulkan target
mei-ye opened a new pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
enable amd_apu device on vulkan target.
@tqchen, @tmoreau89
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632969624
Could you also add in the comments that there are a couple fixes applied to the Vulkan runtime? Because this PR could be technically split into two (bug fixes to Vulkan runtime for GPUs, and adding the V1000 target)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 merged pull request #5659: [TARGET] enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5659: enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632929975
Thanks @mei-ye , assigning @tmoreau89 BTW, you do not have to reopen another PR for the updates, you can just force push to your original branch and the PR will be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 closed pull request #5659: [TARGET] enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
tmoreau89 closed pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632969425
Never mind the other PR was already closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632969349
Thanks you @mei-ye I'll close your other PR since it's a duplicate of this one.
One question: do you also intend on uploading logs into TopHub for the v1000?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mei-ye commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
mei-ye commented on pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632981824
yes, I will check in log to tophub after this. This also fixes two bugs in vulkan runtime:
maxComputeWorkGroupInvocations: the maximum total number of compute shader invocations in a single local workgroup.
maxComputeWorkGroupSize[3]: the maximum size of a local compute workgroup, per dimension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #5659:
URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-634124725
Thank you @mei-ye the PR has been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org