[GitHub] [beam] boyuanzz commented on a change in pull request #14072: Merge Fn API and runner v2 configurations for DataflowRunner

[GitBox <gi...@apache.org>]

boyuanzz commented on a change in pull request #14072:
URL: https://github.com/apache/beam/pull/14072#discussion_r582520260



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -2332,7 +2326,9 @@ static String getContainerImageForJob(DataflowPipelineOptions options) {
   }
 
   static boolean useUnifiedWorker(DataflowPipelineOptions options) {
-    return hasExperiment(options, "use_runner_v2") || hasExperiment(options, "use_unified_worker");
+    return hasExperiment(options, "beam_fn_api")
+        || hasExperiment(options, "use_runner_v2")

Review comment:
       IIRC, if we only specify `beam_fn_api`, we will go with JRH unless we have added runner v2 variants automatically somewhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org