You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "jasperjiaguo (via GitHub)" <gi...@apache.org> on 2023/05/23 20:53:04 UTC
[GitHub] [pinot] jasperjiaguo opened a new pull request, #10798: Enhance the test cases for query killing to reduce the log size and fix a flaky test
jasperjiaguo opened a new pull request, #10798:
URL: https://github.com/apache/pinot/pull/10798
https://github.com/apache/pinot/issues/10768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jasperjiaguo commented on pull request #10798: Enhance the test cases for query killing to reduce the log size and fix a flaky test
Posted by "jasperjiaguo (via GitHub)" <gi...@apache.org>.
jasperjiaguo commented on PR #10798:
URL: https://github.com/apache/pinot/pull/10798#issuecomment-1560227275
> Can you please explain why was the test was flaky, and how is it fixed?
Added to the description, ptal. @jtao15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10798: Enhance the test cases for query killing to reduce the log size and fix a flaky test
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10798:
URL: https://github.com/apache/pinot/pull/10798#issuecomment-1560192703
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10798](https://app.codecov.io/gh/apache/pinot/pull/10798?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (48da0df) into [master](https://app.codecov.io/gh/apache/pinot/commit/101b27e2d014e016a5c2ac787c42a04b206ea4b2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (101b27e) will **increase** coverage by `34.50%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #10798 +/- ##
=============================================
+ Coverage 34.51% 69.01% +34.50%
- Complexity 462 6492 +6030
=============================================
Files 2159 2159
Lines 116002 116002
Branches 17560 17560
=============================================
+ Hits 40038 80061 +40023
+ Misses 72481 30337 -42144
- Partials 3483 5604 +2121
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `23.79% <ø> (+0.02%)` | :arrow_up: |
| unittests1 | `67.91% <ø> (?)` | |
| unittests2 | `13.68% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1350 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10798/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jtao15 commented on a diff in pull request #10798: Enhance the test cases for query killing to reduce the log size and fix a flaky test
Posted by "jtao15 (via GitHub)" <gi...@apache.org>.
jtao15 commented on code in PR #10798:
URL: https://github.com/apache/pinot/pull/10798#discussion_r1203043474
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterMemBasedBrokerQueryKillingTest.java:
##########
@@ -137,6 +129,14 @@ public void setUp()
//Wait for all documents loaded
waitForAllDocsLoaded(10_000L);
+
+ // Setup logging and resource accounting
+ LogManager.getLogger(OfflineClusterMemBasedBrokerQueryKillingTest.class).setLevel(Level.INFO);
+ LogManager.getLogger(PerQueryCPUMemAccountantFactory.PerQueryCPUMemResourceUsageAccountant.class)
+ .setLevel(Level.INFO);
+ LogManager.getLogger(ThreadResourceUsageProvider.class).setLevel(Level.INFO);
+ LogManager.getLogger(Tracing.class).setLevel(Level.INFO);
+ LogManager.getLogger(ThreadResourceUsageProvider.class).setLevel(Level.INFO);
Review Comment:
This is duplicate of `L137`? Same for other setUp() functions as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] jasperjiaguo commented on a diff in pull request #10798: Enhance the test cases for query killing to reduce the log size and fix a flaky test
Posted by "jasperjiaguo (via GitHub)" <gi...@apache.org>.
jasperjiaguo commented on code in PR #10798:
URL: https://github.com/apache/pinot/pull/10798#discussion_r1203117580
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterMemBasedBrokerQueryKillingTest.java:
##########
@@ -137,6 +129,14 @@ public void setUp()
//Wait for all documents loaded
waitForAllDocsLoaded(10_000L);
+
+ // Setup logging and resource accounting
+ LogManager.getLogger(OfflineClusterMemBasedBrokerQueryKillingTest.class).setLevel(Level.INFO);
+ LogManager.getLogger(PerQueryCPUMemAccountantFactory.PerQueryCPUMemResourceUsageAccountant.class)
+ .setLevel(Level.INFO);
+ LogManager.getLogger(ThreadResourceUsageProvider.class).setLevel(Level.INFO);
+ LogManager.getLogger(Tracing.class).setLevel(Level.INFO);
+ LogManager.getLogger(ThreadResourceUsageProvider.class).setLevel(Level.INFO);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia merged pull request #10798: Enhance the test cases for query killing to reduce the log size and fix a flaky test
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia merged PR #10798:
URL: https://github.com/apache/pinot/pull/10798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org