You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/10/30 19:40:33 UTC
[GitHub] spark pull request #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/19612
[SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala 2.12
## What changes were proposed in this pull request?
Spark REPL changes for Scala 2.12.4: use command(), not processLine() in ILoop; remove direct dependence on older jline. Not sure whether this became needed in 2.12.4 or just missed this before. This makes spark-shell work in 2.12.
## How was this patch tested?
Existing tests; manual run of spark-shell in 2.11, 2.12 builds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-14650.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19612.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19612
----
commit a2ccbf221a8ef65f3db85c106cfcc488995d9768
Author: Sean Owen <so...@cloudera.com>
Date: 2017-10-30T19:38:54Z
Spark REPL changes for Scala 2.12.4: use command(), not processLine() in ILoop; remove direct dependence on older jline
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19612
(Note this is a follow-up to https://github.com/apache/spark/pull/19307)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19612
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19612
**[Test build #3969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3969/testReport)** for PR 19612 at commit [`e4f5282`](https://github.com/apache/spark/commit/e4f528209a9b580e3e214dae32648c7709f9f79f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for...
Posted by srowen <gi...@git.apache.org>.
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/19612
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19612
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83227/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19612
**[Test build #83228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83228/testReport)** for PR 19612 at commit [`e4f5282`](https://github.com/apache/spark/commit/e4f528209a9b580e3e214dae32648c7709f9f79f).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19612#discussion_r147812554
--- Diff: pom.xml ---
@@ -1921,11 +1921,6 @@
<version>${antlr4.version}</version>
</dependency>
<dependency>
- <groupId>jline</groupId>
--- End diff --
This caused a problem in Scala 2.12, but, doesn't seem like we have any direct dependency on jline anyway
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/19612#discussion_r147812694
--- Diff: repl/scala-2.12/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
@@ -64,10 +61,10 @@ class SparkILoop(in0: Option[BufferedReader], out: JPrintWriter)
_sc
}
""")
- processLine("import org.apache.spark.SparkContext._")
- processLine("import spark.implicits._")
- processLine("import spark.sql")
- processLine("import org.apache.spark.sql.functions._")
+ command("import org.apache.spark.SparkContext._")
--- End diff --
This was the real change. Also part of the reason Spark didn't work in 2.11.11. This avoids waiting on `ILoop.globalFuture` which isn't initialized when processLine gets called anymore
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19612
**[Test build #83227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83227/testReport)** for PR 19612 at commit [`a2ccbf2`](https://github.com/apache/spark/commit/a2ccbf221a8ef65f3db85c106cfcc488995d9768).
* This patch **fails build dependency tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19612
**[Test build #3969 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3969/testReport)** for PR 19612 at commit [`e4f5282`](https://github.com/apache/spark/commit/e4f528209a9b580e3e214dae32648c7709f9f79f).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19612
**[Test build #83227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83227/testReport)** for PR 19612 at commit [`a2ccbf2`](https://github.com/apache/spark/commit/a2ccbf221a8ef65f3db85c106cfcc488995d9768).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19612: [SPARK-14650][REPL][BUILD] Compile Spark REPL for Scala ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19612
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org