allura git commit: Fix git merge requests to not update project last_updated when viewed.

[ke...@apache.org]

Repository: allura
Updated Branches:
  refs/heads/master 4f62f62e2 -> de310f2c2


Fix git merge requests to not update project last_updated when viewed.

On merge requests, the sidebar_menu logic to reorder branches (
branches.remove and branches.insert) were often acting on a ming
instrumented list.  That caused the change to be recorded as a change
to the project.  Now the caching code returns a plain list, never
and instrumented one, so that can't happen.

Not sure why this was apparently only happening on merge request
views and not other repo pages, but a good change nonetheless.


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/de310f2c
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/de310f2c
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/de310f2c

Branch: refs/heads/master
Commit: de310f2c29e73a984774a7ca946dd0c143cb92be
Parents: 4f62f62
Author: Dave Brondsema <da...@brondsema.net>
Authored: Mon Dec 18 12:07:27 2017 -0500
Committer: Dave Brondsema <da...@brondsema.net>
Committed: Mon Dec 18 12:07:27 2017 -0500

----------------------------------------------------------------------
 ForgeGit/forgegit/model/git_repo.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/de310f2c/ForgeGit/forgegit/model/git_repo.py
----------------------------------------------------------------------
diff --git a/ForgeGit/forgegit/model/git_repo.py b/ForgeGit/forgegit/model/git_repo.py
index ebaf155..0fae9d2 100644
--- a/ForgeGit/forgegit/model/git_repo.py
+++ b/ForgeGit/forgegit/model/git_repo.py
@@ -553,7 +553,7 @@ class GitImplementation(M.RepositoryImplementation):
         cache = getattr(self._repo, cache_name, None)
 
         if cache:
-            return cache
+            return cache._deinstrument()  # always return a plain list
 
         refs = []
         start_time = time()