You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by cr...@apache.org on 2002/06/30 05:55:25 UTC

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/bean WriteTag.java

craigmcc    2002/06/29 20:55:25

  Modified:    src/share/org/apache/struts/taglib/bean WriteTag.java
  Log:
  Do not attempt to pre-initialize "bundle" and "localeKey" to non-null
  values.  This gets messed up in containers that reuse tag instances.
  
  PR: Bugzilla #10257
  Submitted by:  Xavier Poinsard <xpoinsard at openpricer.com>
  
  Revision  Changes    Path
  1.20      +8 -7      jakarta-struts/src/share/org/apache/struts/taglib/bean/WriteTag.java
  
  Index: WriteTag.java
  ===================================================================
  RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/WriteTag.java,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- WriteTag.java	7 Mar 2002 00:24:34 -0000	1.19
  +++ WriteTag.java	30 Jun 2002 03:55:25 -0000	1.20
  @@ -246,7 +246,7 @@
       /**
        * The session scope key under which our Locale is stored.
        */
  -    protected String localeKey = Action.LOCALE_KEY;
  +    protected String localeKey = null;
   
       public String getLocale() {
           return (this.localeKey);
  @@ -259,7 +259,7 @@
       /**
        * The servlet context attribute key for our resources.
        */
  -    protected String bundle = Action.MESSAGES_KEY;
  +    protected String bundle = null;
   
       public String getBundle() {
           return (this.bundle);
  @@ -334,7 +334,8 @@
       protected String formatValue(Object valueToFormat) throws JspException {
           Format format = null;
           Object value = valueToFormat;
  -        Locale locale = RequestUtils.retrieveUserLocale( pageContext, this.localeKey );
  +        Locale locale =
  +            RequestUtils.retrieveUserLocale( pageContext, this.localeKey );
           boolean formatStrFromResources = false;
           String formatString = formatStr;
   
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>