[GitHub] [airflow] ashb commented on a change in pull request #6211: [AIRFLOW-5569] Improve Pod Launcher Logging

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #6211: [AIRFLOW-5569] Improve Pod Launcher Logging
URL: https://github.com/apache/airflow/pull/6211#discussion_r329492261
 
 

 ##########
 File path: airflow/kubernetes/pod_launcher.py
 ##########
 @@ -218,14 +218,16 @@ def _extract_xcom(self, pod: V1Pod):
 
     def _exec_pod_command(self, resp, command):
         if resp.is_open():
-            self.log.info('Running command... %s\n', command)
+            self.log.info('Running command... %s', command)
             resp.write_stdin(command + '\n')
             while resp.is_open():
                 resp.update(timeout=1)
                 if resp.peek_stdout():
-                    return resp.read_stdout()
+                    stdout = resp.read_stdout()
+                    self.log.info("Stdout: %s", stdout.rstrip())
 
 Review comment:
   This is going to "duplicate" the XCom result I think - once from the command output, and again from the log on line 134.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services