[GitHub] [helix] alirezazamani commented on a change in pull request #1142: (WIP) Respect Maximum Number Of Attempts for the tasks

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1142:
URL: https://github.com/apache/helix/pull/1142#discussion_r455396910



##########
File path: helix-core/src/main/java/org/apache/helix/task/AbstractTaskDispatcher.java
##########
@@ -185,17 +185,13 @@ public void updatePreviousAssignedTasksStatus(
         switch (currState) {
         case RUNNING: {
           TaskPartitionState nextState = TaskPartitionState.RUNNING;
-          if (jobState == TaskState.TIMING_OUT) {
+          if (jobState == TaskState.TIMING_OUT || jobState == TaskState.TIMED_OUT
+              || jobState == TaskState.FAILING || jobState == TaskState.FAILED
+              || jobState == TaskState.ABORTED) {

Review comment:
       Done. I create a list for these states. Yes and also make sure task goes to ABORTED state and we release quota.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org