You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/12 20:03:34 UTC
[GitHub] [nuttx-apps] acassis opened a new pull request, #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
acassis opened a new pull request, #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492
## Summary
Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
## Impact
Now users will get it working because it selects automatically the required features
## Testing
ESP32-DEVKIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] acassis commented on pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#issuecomment-1401849090
@xiaoxiang781216 could you please merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] acassis commented on pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#issuecomment-1400507539
> @acassis some defconfig is still not normalized?
@xiaoxiang781216 I did a git pull here in my upstream branch and did:
$ ./tools/refresh.sh --silent --defaults all
$ git diff
It didn't show any defconfig modified. I'll force the github CI to tested, let see!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] btashton commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "btashton (via GitHub)" <gi...@apache.org>.
btashton commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1083485157
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
> Alternately it would be cool if autogenerated docs from the Kconfigs could show everything and explain the dependencies. We could probably do this.
I actually did this a year ago (closed the PR) because it took forever to render all the documentation pages because of how many configs we have :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] acassis commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1083455594
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
Fixed, doesn't enable it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] acassis commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1069458298
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
I don't like the idea of using 'depend on' when the dependent features is not enabled by default. It will hide the current feature from user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] hartmannathan commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1083464226
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
Too bad there isn't a feature in the Kconfig menu to show all features, including those with missing dependent features. By default they would be hidden, but the user could show all features to find out what other possibilities exist. This would require opening a PR with Kconfig-frontends. I think that's [here](https://github.com/uvc-ingenieure/kconfig-frontends) now? (Not sure if that's ahead or behind the one we've used in the past.)
Alternately it would be cool if autogenerated docs from the Kconfigs could show everything and explain the dependencies. We could probably do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#issuecomment-1400078326
@acassis some defconfig is still not normalized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] acassis closed pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis closed pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
URL: https://github.com/apache/nuttx-apps/pull/1492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1068609704
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
should we add depends on ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] btashton commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "btashton (via GitHub)" <gi...@apache.org>.
btashton commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1083520935
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
> Do you have the PR still? Maybe it's possible to speed it up by using a different algorithm. If Kconfig can process it quickly, then a tool to convert it to documentation should be able to do its thing quickly, too. I'm willing to look into it if there's some kind of starting point to put me on the right path :-)
https://github.com/apache/nuttx/pull/3608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] btashton commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "btashton (via GitHub)" <gi...@apache.org>.
btashton commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1083484627
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
I actually did this a year ago (closed the PR) because it took forever to render all the documentation pages because of how many configs we have :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] acassis commented on pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#issuecomment-1381893106
Ok, I think new solution is better, I will sent a patch proposing to enable FS_TMPFS by default if !DEFAULT_SMALL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] hartmannathan commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1083520359
##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
bool "Enable commands as parameters"
default !DEFAULT_SMALL
depends on !DISABLE_MOUNTPOINT
+ select FS_TMPFS
+ select NSH_QUOTE
Review Comment:
Do you have the PR still? Maybe it's possible to speed it up by using a different algorithm. If Kconfig can process it quickly, then a tool to convert it to documentation should be able to do its thing quickly, too. I'm willing to look into it if there's some kind of starting point to put me on the right path :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] jerpelea merged pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org