[jira] [Comment Edited] (MSHADE-411) When Shade finds overlapping classes, clarify which class is added to final artifact

["John Hendrikx (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505098#comment-17505098 ] 

John Hendrikx edited comment on MSHADE-411 at 3/11/22, 7:42 PM:
----------------------------------------------------------------

I'm not sure what you are saying, could you explain this a bit more?


was (Author: john16384):
I'm not sure what you are saying, could you explain this it a bit more?

> When Shade finds overlapping classes, clarify which class is added to final artifact
> ------------------------------------------------------------------------------------
>
>                 Key: MSHADE-411
>                 URL: https://issues.apache.org/jira/browse/MSHADE-411
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>            Reporter: John Hendrikx
>            Priority: Minor
>
> For example:
> [WARNING] mediasystem-jfx-2.0.0-SNAPSHOT.jar, javafx-controls-16-win.jar define 5 overlapping classes:
> [WARNING] - javafx.scene.control.skin.SpinnerSkin$2
> [WARNING] - javafx.scene.control.skin.SpinnerSkin
> [WARNING] - javafx.scene.control.skin.SpinnerSkin$1
> [WARNING] - javafx.scene.control.skin.SpinnerSkin$4
> [WARNING] - javafx.scene.control.skin.SpinnerSkin$3
> Here I purposely override the SpinnerSkin class to fix a bug. But it is unclear which version eventually will make it in the uber.jar (I'm hoping it takes it from the first jar listed).
> I could not find anything on the website, faq, stackoverflow that clarifies *which* version of the class gets included.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)