You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/27 15:49:33 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #13274: [Improvement][Worker] Startup parameter should have the highest priority

EricGao888 commented on code in PR #13274:
URL: https://github.com/apache/dolphinscheduler/pull/13274#discussion_r1057754848


##########
docs/docs/en/guide/parameter/context.md:
##########
@@ -78,7 +78,7 @@ The result of Node_mysql is as follows:
 
 ![context-log03](../../../../img/new_ui/dev/parameter/context_log03.png)
 
-Even though output is assigned a value of 1 in Node_A's script, the log still shows a value of 100. But according to the principle from [parameter priority](priority.md): `Local Parameter > Parameter Context > Global Parameter`, the output value in Node_B is 1. It proves that the output parameter is passed in the workflow with reference to the expected value, and the query operation is completed using this value in Node_mysql.
+Even though output is assigned a value of 1 in Node_A's script, the log still shows a value of 100. But according to the principle from [parameter priority](priority.md): `Startup Parameter > Local Parameter > Parameter Context > Global Parameter`, the output value in Node_B is 1. It proves that the output parameter is passed in the workflow with reference to the expected value, and the query operation is completed using this value in Node_mysql.

Review Comment:
   Looks like we have docs for `Local Parameter`, `Parameter Context` and `Global Parameter`. I think it will be better if you could add some brief explanations on what is `startup parameter` here, since `startup parameter` may cause confusion to users who are not familiar with DS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org