You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/06 11:17:53 UTC

[GitHub] [cloudstack] joschi36 opened a new issue, #6212: Export Virtual Router Health Checks to Prometheus

joschi36 opened a new issue, #6212:
URL: https://github.com/apache/cloudstack/issues/6212

   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and main branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
    * Enhancement Request
   
   ##### COMPONENT NAME
   API, VR
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on main branch.
   -->
   
   ~~~
   4.16.0.0
   ~~~
   But after my research, not available in current versions.
   
   ##### CONFIGURATION
   N/A
   
   
   ##### OS / ENVIRONMENT
   N/A
   
   
   ##### SUMMARY
   For monitoring of Virtual Routers, there seems to be no way of having the health check results in Prometheus metrics endpoint.
   
   Currently, we are querying health check results with a pull based method for every Virtual Router, that is really inefficient on a large scale of routers.
   
   ##### STEPS TO REPRODUCE
   - Enable Prometheus Metrics
   - Enable VR Health Checks
   - Query CloudStack `/metrics` endpoint
   
   ##### EXPECTED RESULTS
   Have VR health check metrics exported at the `/metrics` endpoint.
   
   I thought of something like this, according to the current output of `getRouterHealthCheckResults`:
   
   ~~~ini
   # TYPE cloudstack_virtualrouter_healthcheck_result stateset
   # HELP cloudstack_virtualrouter_healthcheck_result Virtual Router Health Check result
   cloudstack_virtualrouter_healthcheck_result{checkname="connectivity.test",zone="zone1",virtualrouter="i-123456-VM",network="test-network"} 1
   
   # TYPE cloudstack_virtualrouter_healthcheck_lastcheck gauge
   # HELP cloudstack_virtualrouter_healthcheck_lastcheck Virtual Router Health Check lastcheck timestamp
   # UNIT cloudstack_virtualrouter_healthcheck_lastcheck seconds
   cloudstack_virtualrouter_healthcheck_lastcheck{checkname="connectivity.test",zone="zone1",virtualrouter="i-123456-VM",network="test-network"} 1649228157
   ~~~
   
   Maybe this is not 100% accurate to OpenMetrics, but I tried to follow the guidelines. Maybe somebody with more knowledge can have a look.
   
   A drawback with this solution would be that we lose information of the check result message, as Prometheus is not designed to handle this.
   
   ##### ACTUAL RESULTS
   Virtual Router Health Checks not present on the CloudStack Prometheus metrics endpoint
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on issue #6212: Export Virtual Router Health Checks to Prometheus

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #6212:
URL: https://github.com/apache/cloudstack/issues/6212#issuecomment-1603971822

   @NuxRo can you have a look at this? It seems to me the healthcheck output is a bit much for a prometheus interface. But if we feel it is reasonable ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on issue #6212: Export Virtual Router Health Checks to Prometheus

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on issue #6212:
URL: https://github.com/apache/cloudstack/issues/6212#issuecomment-1217986107

   Possible to add new metrics https://github.com/apache/cloudstack/pull/4438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org