You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/05 02:34:02 UTC

[GitHub] [pulsar] HQebupt opened a new pull request, #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

HQebupt opened a new pull request, #15934:
URL: https://github.com/apache/pulsar/pull/15934

   ### Motivation
   Both of ` loadBalancerSheddingGracePeriodMinutes` and `loadBalancerResourceQuotaUpdateIntervalMinutes` are configurable for `ModularLoadManagerImpl` strategy . But the explanation is incorrect.
   The explanation about  `loadBalancerSheddingGracePeriodMinutes` and `loadBalancerResourceQuotaUpdateIntervalMinutes`  distract me to config the `ModularLoadManagerImpl` strategy.
   
   ### Modifications
   Clarify the parameter meaning.
   
   ### Verifying this change
   
   - [x]  Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   ### Does this pull request potentially affect one of the following parts:
   
   If `yes` was chosen, please highlight the changes
   
   - Dependencies (does it add or upgrade a dependency): (no)
   - The public API: (no)
   - The schema: (no)
   - The default values of configurations: (no)
   - The wire protocol: (no)
   - The rest endpoints: (no)
   - The admin cli options: (no)
   - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs?
   
   - [ ] `doc-required`
   
   - [ ] `doc-not-needed`
   
   - [x] `doc`
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#issuecomment-1146979454

   @codelipenghui @hangc0276 can you help review it from technical perspective? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
HQebupt commented on code in PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#discussion_r890889916


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2000,7 +2000,8 @@ public class ServiceConfiguration implements PulsarConfiguration {
     @FieldContext(
         category = CATEGORY_LOAD_BALANCER,
         deprecated = true,
-        doc = "Usage threshold to determine a broker as under-loaded (only used by SimpleLoadManagerImpl)"
+        doc = "Usage threshold to determine a broker as under-loaded (used by SimpleLoadManagerImpl and "
+                + "ModularLoadManagerImpl)"

Review Comment:
   Sure. https://github.com/apache/pulsar/blob/304b03e7ff3eeff62c31f93738af488eb44abde0/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L646-L647
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on a diff in pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
Jason918 commented on code in PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#discussion_r890723964


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2000,7 +2000,8 @@ public class ServiceConfiguration implements PulsarConfiguration {
     @FieldContext(
         category = CATEGORY_LOAD_BALANCER,
         deprecated = true,
-        doc = "Usage threshold to determine a broker as under-loaded (only used by SimpleLoadManagerImpl)"
+        doc = "Usage threshold to determine a broker as under-loaded (used by SimpleLoadManagerImpl and "
+                + "ModularLoadManagerImpl)"

Review Comment:
   Can you point out where this is used in `ModularLoadManagerImpl`？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
HQebupt commented on code in PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#discussion_r890889916


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2000,7 +2000,8 @@ public class ServiceConfiguration implements PulsarConfiguration {
     @FieldContext(
         category = CATEGORY_LOAD_BALANCER,
         deprecated = true,
-        doc = "Usage threshold to determine a broker as under-loaded (only used by SimpleLoadManagerImpl)"
+        doc = "Usage threshold to determine a broker as under-loaded (used by SimpleLoadManagerImpl and "
+                + "ModularLoadManagerImpl)"

Review Comment:
   Ignore the PR. I made a mistake.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#issuecomment-1146805254

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on a diff in pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
HQebupt commented on code in PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#discussion_r890889916


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2000,7 +2000,8 @@ public class ServiceConfiguration implements PulsarConfiguration {
     @FieldContext(
         category = CATEGORY_LOAD_BALANCER,
         deprecated = true,
-        doc = "Usage threshold to determine a broker as under-loaded (only used by SimpleLoadManagerImpl)"
+        doc = "Usage threshold to determine a broker as under-loaded (used by SimpleLoadManagerImpl and "
+                + "ModularLoadManagerImpl)"

Review Comment:
   Sure. https://github.com/apache/pulsar/blob/304b03e7ff3eeff62c31f93738af488eb44abde0/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L637-L647
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt closed pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
HQebupt closed pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes
URL: https://github.com/apache/pulsar/pull/15934


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #15934: [improve][doc] add explanations for loadBalancerSheddingGracePeriodMinutes and loadBalancerResourceQuotaUpdateIntervalMinutes

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #15934:
URL: https://github.com/apache/pulsar/pull/15934#issuecomment-1148335927

   Ignore the PR. I made a mistake.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org