You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2015/12/02 06:12:45 UTC

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/500

    Fix navbar-brand image margin

    Currently, because of overlapping #483 #469,
    http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/ navbar-brand image location is little bit wired. 
    ![before](https://github.com/AhyoungRyu/Platform-Documentation/blob/master/compared_img/Before_NavbarImg.png?raw=true)
    
    So I fixed this. Additionally, I deleted some traces generated by last merge.
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/incubator-zeppelin fix-navbar-brand-img-margin

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #500
    
----
commit 16984b3ea625bbc3a0bf2ebfe2f6a78fd86ccace
Author: Ryu Ah young <fb...@hanmail.net>
Date:   2015-12-02T04:53:27Z

    fix navbar-brand image margin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

Posted by r-kamath <gi...@git.apache.org>.

Github user r-kamath commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/500#issuecomment-161577146
  
    :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/500#issuecomment-161567563
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/500#issuecomment-161810947
  
    I'm merging it into the master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/500#issuecomment-161826815
  
    :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/500


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Fix navbar-brand image margin

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/500#issuecomment-161539866
  
    Just tried it, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---