svn commit: r1881495 - in /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox: cos/TestCOSString.java encryption/TestSymmetricKeyEncryption.java pdmodel/common/COSArrayListTest.java

[ti...@apache.org]

Author: tilman
Date: Sat Sep  5 16:07:14 2020
New Revision: 1881495

URL: http://svn.apache.org/viewvc?rev=1881495&view=rev
Log:
PDFBOX-4892: SonarQube fix

Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSString.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestSymmetricKeyEncryption.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSString.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSString.java?rev=1881495&r1=1881494&r2=1881495&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSString.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/cos/TestCOSString.java Sat Sep  5 16:07:14 2020
@@ -210,7 +210,7 @@ public class TestCOSString extends TestC
     {
         String theString = "\u4e16";
         COSString string = new COSString(theString);
-        assertTrue(string.getString().equals(theString));
+        Assert.assertEquals(string.getString(), theString);
         
         String textAscii = "This is some regular text. It should all be expressible in ASCII";
         /** En français où les choses sont accentués. En español, así */

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestSymmetricKeyEncryption.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestSymmetricKeyEncryption.java?rev=1881495&r1=1881494&r2=1881495&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestSymmetricKeyEncryption.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/encryption/TestSymmetricKeyEncryption.java Sat Sep  5 16:07:14 2020
@@ -379,9 +379,9 @@ public class TestSymmetricKeyEncryption
         doc.save(pdfFile);
         doc.close();
         long sizeEncrypted = pdfFile.length();
-        Assert.assertTrue(keyLength
+        Assert.assertNotEquals(keyLength
                 + "-bit " + (preferAES ? "AES" : "RC4") + " encrypted pdf should not have same size as plain one",
-                sizeEncrypted != sizePriorToEncr);
+                sizeEncrypted, sizePriorToEncr);
 
         // test with owner password => full permissions
         PDDocument encryptedDoc = Loader.loadPDF(pdfFile, ownerpassword);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java?rev=1881495&r1=1881494&r2=1881495&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/common/COSArrayListTest.java Sat Sep  5 16:07:14 2020
@@ -115,12 +115,12 @@ public class COSArrayListTest {
 
         for (int i = 0; i < cosArrayList.size(); i++) {
             PDAnnotation annot = cosArrayList.get(i);
-            assertTrue("PDAnnotations cosObject at " + i + " shall be equal to index " + i + " of COSArray",
-                annotationsArray.get(i).equals(annot.getCOSObject()));
+            assertEquals("PDAnnotations cosObject at " + i + " shall be equal to index " + i + " of COSArray",
+                annotationsArray.get(i), annot.getCOSObject());
 
             // compare with Java List/Array
-            assertTrue("PDAnnotations at " + i + " shall be at index " + i + " of List",
-                tbcAnnotationsList.get(i).equals((annot)));
+            assertEquals("PDAnnotations at " + i + " shall be at index " + i + " of List",
+                tbcAnnotationsList.get(i), annot);
             assertEquals("PDAnnotations cosObject at " + i + " shall be at position " + i + " of Array",
                 tbcAnnotationsArray[i], annot.getCOSObject());
         }