You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Created) (JIRA)" <ji...@apache.org> on 2012/03/21 22:55:39 UTC
[jira] [Created] (CASSANDRA-4072) Clean up DataOutputBuffer
Clean up DataOutputBuffer
-------------------------
Key: CASSANDRA-4072
URL: https://issues.apache.org/jira/browse/CASSANDRA-4072
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
The DataOutputBuffer/OutputBuffer split is unnecessarily baroque.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4072) Clean up DataOutputBuffer
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4072:
--------------------------------------
Attachment: 4072.txt
Patch inlines the relevant parts of OB into DOB. Also replaces FBOS+getBytes with DOB+getData in a couple places that look performance-sensitive-ish.
> Clean up DataOutputBuffer
> -------------------------
>
> Key: CASSANDRA-4072
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4072
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 4072.txt
>
>
> The DataOutputBuffer/OutputBuffer split is unnecessarily baroque.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4072) Clean up DataOutputBuffer
Posted by "Jonathan Ellis (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-4072.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.1
I was thinking we should avoid the cast since that is not free at runtime, but getData and getLength are typically only called once so you're right, that's premature optimization.
Committed w/ that change and the comment reformat.
> Clean up DataOutputBuffer
> -------------------------
>
> Key: CASSANDRA-4072
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4072
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.1.1
>
> Attachments: 4072.txt
>
>
> The DataOutputBuffer/OutputBuffer split is unnecessarily baroque.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4072) Clean up DataOutputBuffer
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239461#comment-13239461 ]
Sylvain Lebresne commented on CASSANDRA-4072:
---------------------------------------------
Looks good, +1 with the two following nits:
* maybe in DOB we could avoid storing the FBOS reference since we can access it through the (protected) out field of DOS (we'll need a cast, but storing 2 refs in the same object to the same object bugs my OCD). Anyway, I'm good with or without that change.
* in CompositeType.java, there's a mis-indented comment.
> Clean up DataOutputBuffer
> -------------------------
>
> Key: CASSANDRA-4072
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4072
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Attachments: 4072.txt
>
>
> The DataOutputBuffer/OutputBuffer split is unnecessarily baroque.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4072) Clean up DataOutputBuffer
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4072:
--------------------------------------
Component/s: Core
Priority: Minor (was: Major)
Assignee: Jonathan Ellis
> Clean up DataOutputBuffer
> -------------------------
>
> Key: CASSANDRA-4072
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4072
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
>
> The DataOutputBuffer/OutputBuffer split is unnecessarily baroque.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira