You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "balancehero-neal (via GitHub)" <gi...@apache.org> on 2023/04/15 04:22:40 UTC
[GitHub] [fineract] balancehero-neal opened a new pull request, #3127: [FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups
balancehero-neal opened a new pull request, #3127:
URL: https://github.com/apache/fineract/pull/3127
## Description
Issue: [FINERACT-1875](https://issues.apache.org/jira/browse/FINERACT-1875)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #3127: [FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3127:
URL: https://github.com/apache/fineract/pull/3127#issuecomment-1585300011
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #3127: [FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #3127:
URL: https://github.com/apache/fineract/pull/3127#issuecomment-1541613691
@balancehero-neal is this being worked on or abandoned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] balancehero-neal commented on pull request #3127: [FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups
Posted by "balancehero-neal (via GitHub)" <gi...@apache.org>.
balancehero-neal commented on PR #3127:
URL: https://github.com/apache/fineract/pull/3127#issuecomment-1510096694
@galovics
I'm checking Integration Test Structure. It will require some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] balancehero-neal commented on pull request #3127: [FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups
Posted by "balancehero-neal (via GitHub)" <gi...@apache.org>.
balancehero-neal commented on PR #3127:
URL: https://github.com/apache/fineract/pull/3127#issuecomment-1509497861
I'm a little bit worried that It's okay to add PreparedStatementCreator(feat. ResultSet.TYPE_SCROLL_SENSITIVE) again and again. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics closed pull request #3127: [FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics closed pull request #3127: [FINERACT-1875] Support postgresql compatibility when retrieveAllTaxGroups
URL: https://github.com/apache/fineract/pull/3127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org