You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/02 10:04:40 UTC

[GitHub] [tvm] Mousius commented on a change in pull request #10138: [microTVM][Zephyr] Update RVM to Zephyr 2.7

Mousius commented on a change in pull request #10138:
URL: https://github.com/apache/tvm/pull/10138#discussion_r797443555



##########
File path: docker/install/ubuntu_install_zephyr.sh
##########
@@ -69,10 +68,5 @@ chmod o+rwx zephyr/.cache
 #/opt/west/bin/pip3 install -r /opt/zephyrproject/zephyr/scripts/requirements.txt
 pip3 install -r /opt/zephyrproject/zephyr/scripts/requirements.txt
 
-ZEPHYR_SDK_VERSION=0.13.2
-ZEPHYR_SDK_FILE=zephyr-sdk-linux-setup.run
-wget --no-verbose -O $ZEPHYR_SDK_FILE \
-    https://github.com/zephyrproject-rtos/sdk-ng/releases/download/v${ZEPHYR_SDK_VERSION}/zephyr-sdk-${ZEPHYR_SDK_VERSION}-linux-x86_64-setup.run
-chmod +x $ZEPHYR_SDK_FILE
-"./$ZEPHYR_SDK_FILE" -- -d /opt/zephyr-sdk
-rm "$ZEPHYR_SDK_FILE"
+ZEPHYR_INSTALL_SDK_SCRIPT=$(find -name "ubuntu_install_zephyr_sdk.sh")
+bash ${ZEPHYR_INSTALL_SDK_SCRIPT} /opt/zephyr-sdk

Review comment:
       I think you need to update ci_qemu to `ADD` this additional script, it'd also be better to explicitly `RUN` it rather than chaining them like this to make it clearer what gets run on build.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org