[GitHub] [hudi] danny0405 commented on a diff in pull request #5991: [HUDI-4329] Add separate control for Flink compaction operation sync/async mode

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #5991:
URL: https://github.com/apache/hudi/pull/5991#discussion_r1001603063


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactFunction.java:
##########
@@ -74,14 +74,14 @@ public class CompactFunction extends ProcessFunction<CompactionPlanEvent, Compac
 
   public CompactFunction(Configuration conf) {
     this.conf = conf;
-    this.asyncCompaction = OptionsResolver.needsAsyncCompaction(conf);
+    this.asyncCompactionOperation = OptionsResolver.needsAsyncCompactionOperation(conf);
   }

Review Comment:
   Why switching to a new option key, what's the purpose here ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org