You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by ds...@apache.org on 2010/02/24 23:59:31 UTC
svn commit: r916032 - in /felix/trunk/sigil:
common/core/src/org/apache/felix/sigil/core/repository/SystemRepository.java
eclipse/core/src/org/apache/felix/sigil/eclipse/model/util/JavaHelper.java
Author: dsavage
Date: Wed Feb 24 22:59:31 2010
New Revision: 916032
URL: http://svn.apache.org/viewvc?rev=916032&view=rev
Log:
tidy up npe caused by adding system bundle repository to repository set (FELIX-2133)
Modified:
felix/trunk/sigil/common/core/src/org/apache/felix/sigil/core/repository/SystemRepository.java
felix/trunk/sigil/eclipse/core/src/org/apache/felix/sigil/eclipse/model/util/JavaHelper.java
Modified: felix/trunk/sigil/common/core/src/org/apache/felix/sigil/core/repository/SystemRepository.java
URL: http://svn.apache.org/viewvc/felix/trunk/sigil/common/core/src/org/apache/felix/sigil/core/repository/SystemRepository.java?rev=916032&r1=916031&r2=916032&view=diff
==============================================================================
--- felix/trunk/sigil/common/core/src/org/apache/felix/sigil/core/repository/SystemRepository.java (original)
+++ felix/trunk/sigil/common/core/src/org/apache/felix/sigil/core/repository/SystemRepository.java Wed Feb 24 22:59:31 2010
@@ -85,6 +85,9 @@
info = ModelElementFactory.getInstance().newModelElement( IBundleModelElement.class );
}
+ info.setSymbolicName("system bundle");
+ info.setName("Sigil system bundle");
+
applyProfile( info );
systemBundle.addChild( info );
}
Modified: felix/trunk/sigil/eclipse/core/src/org/apache/felix/sigil/eclipse/model/util/JavaHelper.java
URL: http://svn.apache.org/viewvc/felix/trunk/sigil/eclipse/core/src/org/apache/felix/sigil/eclipse/model/util/JavaHelper.java?rev=916032&r1=916031&r2=916032&view=diff
==============================================================================
--- felix/trunk/sigil/eclipse/core/src/org/apache/felix/sigil/eclipse/model/util/JavaHelper.java (original)
+++ felix/trunk/sigil/eclipse/core/src/org/apache/felix/sigil/eclipse/model/util/JavaHelper.java Wed Feb 24 22:59:31 2010
@@ -351,13 +351,13 @@
}
- public static Collection<IClasspathEntry> resolveClasspathEntrys( ISigilProjectModel newton,
+ public static Collection<IClasspathEntry> resolveClasspathEntrys( ISigilProjectModel sigil,
IProgressMonitor monitor ) throws CoreException
{
if ( monitor == null )
{
monitor = Job.getJobManager().createProgressGroup();
- monitor.beginTask( "Resolving classpath for " + newton.getSymbolicName(), 2 );
+ monitor.beginTask( "Resolving classpath for " + sigil.getSymbolicName(), 2 );
}
ArrayList<IClasspathEntry> entries = new ArrayList<IClasspathEntry>();
@@ -368,7 +368,7 @@
IResolution resolution;
try
{
- resolution = SigilCore.getRepositoryManager( newton ).getBundleResolver().resolve( newton, config,
+ resolution = SigilCore.getRepositoryManager( sigil ).getBundleResolver().resolve( sigil, config,
new ResolutionMonitorAdapter( monitor ) );
}
catch ( ResolutionException e )
@@ -381,10 +381,10 @@
Set<ISigilBundle> bundles = resolution.getBundles();
for ( ISigilBundle bundle : bundles )
{
- if ( !bundle.getBundleInfo().getSymbolicName().equals( newton.getSymbolicName() ) )
+ if ( !sigil.getSymbolicName().equals(bundle.getBundleInfo().getSymbolicName()) )
{ // discard self reference...
List<IModelElement> matched = resolution.getMatchedRequirements( bundle );
- for ( IClasspathEntry cpe : buildClassPathEntry( newton, bundle, bundles, matched, monitor ) )
+ for ( IClasspathEntry cpe : buildClassPathEntry( sigil, bundle, bundles, matched, monitor ) )
{
entries.add( cpe );
}