You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/04 02:53:10 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #8099:
[FLINK-12081][table-planner-blink] Introduce aggregation operator code
generator to blink batch
KurtYoung commented on a change in pull request #8099: [FLINK-12081][table-planner-blink] Introduce aggregation operator code generator to blink batch
URL: https://github.com/apache/flink/pull/8099#discussion_r272000515
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -112,7 +113,7 @@ private RexNode visitScalarFunc(FunctionDefinition def, List<RexNode> child) {
} else if (BuiltInFunctionDefinitions.EQUALS.equals(def)) {
return relBuilder.call(SqlStdOperatorTable.EQUALS, child);
Review comment:
maybe we should change all SqlStdOperatorTable to FlinkSqlOperatorTable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services