You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/30 09:09:04 UTC
[GitHub] [iotdb] zyk990424 opened a new pull request #3650: Feature entity m node
zyk990424 opened a new pull request #3650:
URL: https://github.com/apache/iotdb/pull/3650
## Description
### Set IEntityMNode Interface
IEntityMNode defines the operations on an EntityMNode, in terms of aliasChilren and template usage for the time being. More functions like template lastCache will be implemented based on EntityMNode soon.
### Implement EntityMNode
The EntityMNode will be used when timeseries is created or the template is used on an InternalMNode. The parent node of a MeasurementMNode and node using template will be transform to EntityMNode.
### Implement StorageGroupEntityMNode
To avoid the conflict between StorageGroupMNode and EntityMNode, StorageGroupEntityMNode is implemented combining functions of both side, which means an entity can be a storage group and measurements can be created directly under a storage group path. StorageGroupEntityMNode extends EntityMNode and implements IStorageGroupMNode interface with the same code in StorageGroupMNode.
### Eliminate "instanceof" usage on MNode
Since the number of MNode class is increasing, the performance of instanceof will decrease and be no match to function override. Besides, the usage of instance violates the OO code design.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin commented on a change in pull request #3650: [IOTDB-1511] Implement EntityMNode
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #3650:
URL: https://github.com/apache/iotdb/pull/3650#discussion_r679976642
##########
File path: server/src/test/java/org/apache/iotdb/db/metadata/MManagerBasicTest.java
##########
@@ -1357,7 +1357,7 @@ public void testCountTimeseriesWithTemplate() {
SetDeviceTemplatePlan setDeviceTemplatePlan =
new SetDeviceTemplatePlan("template1", "root.laptop.d1");
manager.setDeviceTemplate(setDeviceTemplatePlan);
- manager.getDeviceNode(new PartialPath("root.laptop.d1")).setUseTemplate(true);
+ manager.setUsingDeviceTemplate(manager.getDeviceNode(new PartialPath("root.laptop.d1")));
Review comment:
```suggestion
manager.setUsingSchemaTemplate(manager.getDeviceNode(new PartialPath("root.laptop.d1")));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3650: [IOTDB-1511] Implement EntityMNode
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3650:
URL: https://github.com/apache/iotdb/pull/3650#issuecomment-889795044
[](https://coveralls.io/builds/41779024)
Coverage decreased (-0.03%) to 68.257% when pulling **66e4cd14201a8c7b2945870a4933ea13c44207c0 on zyk990424:feature_EntityMNode** into **902dbfb6fdda03e5d608dc12f9ebb28177b4fed9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #3650: [IOTDB-1511] Implement EntityMNode
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #3650:
URL: https://github.com/apache/iotdb/pull/3650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3650: [IOTDB-1511] Implement EntityMNode
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3650:
URL: https://github.com/apache/iotdb/pull/3650#issuecomment-889795044
[](https://coveralls.io/builds/41778618)
Coverage decreased (-0.02%) to 68.259% when pulling **66e4cd14201a8c7b2945870a4933ea13c44207c0 on zyk990424:feature_EntityMNode** into **902dbfb6fdda03e5d608dc12f9ebb28177b4fed9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org