[GitHub] [superset] rusackas commented on a diff in pull request #20612: chore(explore): update Explore icons and icon colors

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #20612:
URL: https://github.com/apache/superset/pull/20612#discussion_r933364148


##########
superset-frontend/src/explore/components/ControlHeader.tsx:
##########
@@ -40,6 +40,16 @@ export type ControlHeaderProps = {
   danger?: string;
 };
 
+const iconStyles = css`

Review Comment:
   This is fine for now, but let's talk about this chunk in person sometime. I'd love to be in a state where we don't need to be adding/overriding/tweaking Icon styles in any particular use/implementation, instead adding classes/config/props on the Icon component itself to handle these needs more globally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org