You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "gesterzhou (GitHub)" <gi...@apache.org> on 2019/02/08 00:42:32 UTC
[GitHub] [geode] gesterzhou opened pull request #3175: GEODE-6365:
WIP Added MappingCommandUtil class
- Refactored Mapping Commands to use util class
GEDOE-6365: add ListMappingCommand with tests
GEODE-6365: implement server group parameter in destroy mapping with tests
Signed-off-by: Xiaojian Zhou <gz...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
This doesn't quite make sense. We created 3 mapping with various group values. I would expect the list only show the 3 mappings we created. Here there are 4 mappings in the list result. I would consider one of them duplicate.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 closed pull request #3175: GEODE-6365: Add
server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
[ pull request closed by jchen21 ]
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
What is the status of this command?
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
Now this method name `verifyMappingRemovedFromService ` is misleading. Actually we want to verify the mapping is *not* removed.
Can we change the return value from `void` to `boolean` and rename the method a little bit? So that we can use `assertThat` and make the code easier to read and understand. e.g. for this case, it will be `assertThat(mappingRemovedFromService).isFalse()`
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
Do we still need this private method `checkForRegion `? Since we can call `MappingCommandUtils.checkForRegion(regionName, cacheConfig, groupName)`.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
Now this method name `verifyMappingRemovedFromService ` is misleading. Actually we want to verify the mapping is *not* removed.
Use boolean type as the third parameter does not help understanding the code. In order to figure it out, I have to go to the implementation to see what it does with the boolean parameter.
Can we change the return value from `void` to `boolean` and remove the boolean parameter and rename the method a little bit? So that we can use `assertThat` and make the code easier to read and understand. e.g. for this case, it will be `assertThat(mappingRemovedFromService).isFalse()`.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
This `if` check does nothing?
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
I don't see the code to iterate over the element in the `groups` String array. Something is missing.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
Again, can we add one more `list jdbc-mapping` command without `--group` here?
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
Do we still need this private method `getCacheConfig`? Since we can directly call `MappingCommandUtils.getCacheConfig(configService, group)`.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
What is the status of this command? I am expecting either `statusIsSuccess` or `statusIsError`.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
It looks like you found a bug in isMappingAsync and fixed it by changing the name.
Does this indicate that we are missing a test on DescribeMappingCommand that tests this boolean result?
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
Instead of having the null check here, can we just pass `TEST_REGION` as parameter wherever appropriate? e.g. `verifyQueueRemoved(cache, null, false);` becomes `verifyQueueRemoved(cache, TEST_REGION, false);`. This makes the code easier to read and understand.
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3175: GEODE-6365:
Add server group support for JDBC List Mapping and Destroy Mapping Commands
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
Can we add one more `list jdbc-mapping` command without `--group` here?
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
Add a unit test for this new class
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3175:
GEODE-6365: Add server group support for JDBC List Mapping and Destroy
Mapping Commands
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
✅
[ Full content available at: https://github.com/apache/geode/pull/3175 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org