[GitHub] [superset] eschutho commented on a diff in pull request #22144: feat(ssh_tunnel): Add SSH Tunnel feature flags

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #22144:
URL: https://github.com/apache/superset/pull/22144#discussion_r1025653135


##########
superset/config.py:
##########
@@ -1436,6 +1436,18 @@ def EMAIL_HEADER_MUTATOR(  # pylint: disable=invalid-name,unused-argument
     },
 }
 
+# ------------------------------
+# SSH Tunnel
+# ------------------------------
+# Allow users to enable ssh tunneling when creating a DB.
+# Users must check whether the DB engine supports SSH Tunnels
+# otherwise enabling this flag won't have any effect on the DB.
+SSH_TUNNEL_ENABLE = False

Review Comment:
   I would make this one a feature flag, and the below one a config, like you have it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org