[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6286: Adding offline dimension table creation and segment assignment

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6286:
URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r529805363



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignmentUtils.java
##########
@@ -87,6 +87,15 @@ private SegmentAssignmentUtils() {
     return instances;
   }
 
+  static List<String> getInstancesForDimTable(InstancePartitions instancePartitions) {

Review comment:
       We don't need instance partitions for dimTable. It should be assigned to all the instances under the given tag




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org