You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "eltsovalex (via GitHub)" <gi...@apache.org> on 2023/03/21 16:38:49 UTC
[GitHub] [maven-build-cache-extension] eltsovalex opened a new pull request, #51: [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project
eltsovalex opened a new pull request, #51:
URL: https://github.com/apache/maven-build-cache-extension/pull/51
Added a new flag that allows disabling cache (not just looking up build artifacts, but all the build cache completely).
This may be required in a case when a module is a final leaf of a reactor tree, and its artefacts are not required by other modules as cached dependencies. Hence eliminating some modules from caching will speed up build and also lower the footprint size of a cached build.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] eltsovalex commented on pull request #51: [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project
Posted by "eltsovalex (via GitHub)" <gi...@apache.org>.
eltsovalex commented on PR #51:
URL: https://github.com/apache/maven-build-cache-extension/pull/51#issuecomment-1497146448
> Hi Alex. Regarding the code itself - looks good to me. But please clarify the use case and rationale for the change. Is it for cases where the local build is faster than downloading from the cache? I understand uploading might be expensive, but an existing configuration parameter allows for skipping the upload. And if uploading doesn't happen, I wonder what the benefits are achieved by disabling the cache compared to disabled upload. Thank you!
Hi. Thanks for asking. Sorry for not providing a precise description of my use-case.
So, I have a module in my project that builds a huge EAR of ~200Mb as a target. Due to some specific reasons (e.g. project version written deep down in one of jars inside EAR +some build artifacts required for publishing by CI to be present in target folder) I have to always build that subproject clean (so without caching). And while the previous flag I added last year (maven.build.cache.skipCache) works fine to solve the forced rebuild task - it still uploads the 200Mb EAR to cache. So it spoils the cache with multiple versions of a huge unused file + takes some time for the upload itself. As this is not an attached artefact, but a main goal - I can not add it to ignored/not uploaded.
Hence this new property added that totally disables cache on a per-project level (both lookup and upload)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #51: [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project
Posted by "AlexanderAshitkin (via GitHub)" <gi...@apache.org>.
AlexanderAshitkin commented on PR #51:
URL: https://github.com/apache/maven-build-cache-extension/pull/51#issuecomment-1495195508
Hi Alex.
Please clarify the use case. Is it for cases where building from scratch is faster than using the cache? I understand uploading might be expensive, but an existing configuration parameter allows for skipping the upload. And if uploading doesn't happen, I wonder what the benefits are achieved by disabling the cache compared to disabled upload.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] olamy commented on pull request #51: [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #51:
URL: https://github.com/apache/maven-build-cache-extension/pull/51#issuecomment-1500832518
worth to document the behaviour https://maven.apache.org/extensions/maven-build-cache-extension/parameters.html
e.g this parameter can apply to single module(s) as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-build-cache-extension] olamy merged pull request #51: [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy merged PR #51:
URL: https://github.com/apache/maven-build-cache-extension/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project [maven-build-cache-extension]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #51:
URL: https://github.com/apache/maven-build-cache-extension/pull/51#issuecomment-2955451426
Resolve #307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MBUILDCACHE-48] - Add possibility to disable caching per module in a multi-module project [maven-build-cache-extension]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #51:
URL: https://github.com/apache/maven-build-cache-extension/pull/51#issuecomment-2955464282
Resolve #307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org