You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2020/11/20 16:26:28 UTC

[GitHub] [brooklyn-dist] ahgittin commented on pull request #166: Fixes soap linkage error

ahgittin commented on pull request #166:
URL: https://github.com/apache/brooklyn-dist/pull/166#issuecomment-731268111


   could you add a comment saying what is removed, and/or do this as two commits one which copies the stock jre.properties value and another which removes the relevant ones?
   
   also this will fix it only for jre 1.8.  i wonder whether we'd be better off overwriting the original `jre.properties`, removing the packages we provide explicitly for all JREs.  if not at least a comment to say this overwrites the value from `jre.properties`, and similar might be needed for other jre versions.
   
   so glad it's fixed though!!!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org