[jira] [Commented] (ZOOKEEPER-776) API should sanity check sessionTimeout argument

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342909#comment-15342909 ] 

Hadoop QA commented on ZOOKEEPER-776:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12740443/ZOOKEEPER-776.patch
  against trunk revision 1748630.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3206//console

This message is automatically generated.

> API should sanity check sessionTimeout argument
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-776
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: c client, java client
>    Affects Versions: 3.2.2, 3.3.0, 3.3.1, 3.4.6, 3.5.0
>         Environment: OSX 10.6.3, JVM 1.6.0-20
>            Reporter: Gregory Haskins
>            Assignee: Raul Gutierrez Segales
>            Priority: Minor
>             Fix For: 3.6.0, 3.5.3
>
>         Attachments: ZOOKEEPER-776.patch, zookeeper-776-fix.patch, zookeeper-776-fix.patch, zookeeper-776-fix.patch
>
>
> passing in a "0" sessionTimeout to ZooKeeper() constructor leads to errors in subsequent operations.  It would be ideal to capture this configuration error at the source by throwing something like an IllegalArgument exception when the bogus sessionTimeout is specified, instead of later when it is utilized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)