You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Arne Roomann-Kurrik (JIRA)" <ji...@apache.org> on 2009/10/14 22:10:31 UTC

[jira] Created: (SHINDIG-1191) Strip headers from makeRequest requests/responses

Strip headers from makeRequest requests/responses
-------------------------------------------------

                 Key: SHINDIG-1191
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1191
             Project: Shindig
          Issue Type: Improvement
          Components: PHP
            Reporter: Arne Roomann-Kurrik


Java Shindig removes headers from proxy/makeRequest requests and responses.  I will be attaching a patch to replicate this behavior in PHP Shindig's MakeRequest class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1191) Strip headers from makeRequest requests/responses

Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-1191.
-----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

LGTM, I'll try out a few more gadgets once i've deployed this to partuza.nl, but everything that I've been able to test here locally seems to check out fine

> Strip headers from makeRequest requests/responses
> -------------------------------------------------
>
>                 Key: SHINDIG-1191
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1191
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>            Reporter: Arne Roomann-Kurrik
>            Assignee: Chris Chabot
>         Attachments: issue132043_14.diff
>
>
> Java Shindig removes headers from proxy/makeRequest requests and responses.  I will be attaching a patch to replicate this behavior in PHP Shindig's MakeRequest class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1191) Strip headers from makeRequest requests/responses

Posted by "Arne Roomann-Kurrik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arne Roomann-Kurrik updated SHINDIG-1191:
-----------------------------------------

    Attachment: issue132043_14.diff

Code review at http://codereview.appspot.com/132043/show - All applicable unit tests pass, but please take a careful look that makeRequest and proxied content requests continue to behave as expected.

> Strip headers from makeRequest requests/responses
> -------------------------------------------------
>
>                 Key: SHINDIG-1191
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1191
>             Project: Shindig
>          Issue Type: Improvement
>          Components: PHP
>            Reporter: Arne Roomann-Kurrik
>         Attachments: issue132043_14.diff
>
>
> Java Shindig removes headers from proxy/makeRequest requests and responses.  I will be attaching a patch to replicate this behavior in PHP Shindig's MakeRequest class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.