You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2014/09/15 05:44:34 UTC
[jira] [Commented] (HIVE-8082) generateErrorMessage doesn't handle
null ast properly
[ https://issues.apache.org/jira/browse/HIVE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133546#comment-14133546 ]
Hive QA commented on HIVE-8082:
-------------------------------
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12668688/HIVE-8082.1.patch
{color:green}SUCCESS:{color} +1 6275 tests passed
Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/796/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/796/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-796/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12668688
> generateErrorMessage doesn't handle null ast properly
> -----------------------------------------------------
>
> Key: HIVE-8082
> URL: https://issues.apache.org/jira/browse/HIVE-8082
> Project: Hive
> Issue Type: Bug
> Affects Versions: 0.11.0, 0.12.0, 0.13.0, 0.13.1
> Environment: anything
> Reporter: Darren Yin
> Priority: Minor
> Labels: newbie, patch
> Attachments: HIVE-8082.1.patch
>
>
> in SemanticAnalzyer.genUnionPlan, tabref can be null, and if then one of the "throw new SemanticException" lines gets called, generateErrorMessage will error out with a NullPointerException when ast.getLine() is called. The fix is just to add a check for if (ast == null)
> example stack trace:
> {noformat}
> 2014-09-12 14:02:3014/09/12 21:02:30 ERROR ql.Driver: FAILED: NullPointerException null
> 2014-09-12 14:02:30java.lang.NullPointerException
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.generateErrorMessage(SemanticAnalyzer.java:484)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genUnionPlan(SemanticAnalyzer.java:7411)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:7970)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.genPlan(SemanticAnalyzer.java:7985)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeInternal(SemanticAnalyzer.java:8693)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:278)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:458)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:407)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:339)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.ql.Driver.run(Driver.java:969)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.cli.CliDriver.processLocalCmd(CliDriver.java:261)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:218)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:421)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:356)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.cli.CliDriver.run(CliDriver.java:714)
> 2014-09-12 14:02:30 at org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:622)
> 2014-09-12 14:02:30 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2014-09-12 14:02:30 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 2014-09-12 14:02:30 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 2014-09-12 14:02:30 at java.lang.reflect.Method.invoke(Method.java:597)
> 2014-09-12 14:02:30 at org.apache.hadoop.util.RunJar.main(RunJar.java:208)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)