You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/07 09:55:16 UTC
[GitHub] [iotdb] yifuzhou opened a new pull request, #5823: support show child paths sql
yifuzhou opened a new pull request, #5823:
URL: https://github.com/apache/iotdb/pull/5823
## Description
### Content1 ...
### Content2 ...
### Content3 ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 merged pull request #5823: [IOTDB-3061] Support Show Child Paths/Nodes in Node Management
Posted by GitBox <gi...@apache.org>.
wangchao316 merged PR #5823:
URL: https://github.com/apache/iotdb/pull/5823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on pull request #5823: [IOTDB-2803] Support Show Child Paths/Nodes in Node Management
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on PR #5823:
URL: https://github.com/apache/iotdb/pull/5823#issuecomment-1120738896
It seems the queries on nodes below storage group work well. What about the nodes above storage group? For example, given sg ```root.test1.sg1``` and query ```show child paths root``` or ```show child paths root.test1```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on pull request #5823: [IOTDB-2803] Support Show Child Paths/Nodes in Node Management
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on PR #5823:
URL: https://github.com/apache/iotdb/pull/5823#issuecomment-1120940592
Please add some result screenshot about the cases across storage group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] yifuzhou commented on pull request #5823: [IOTDB-2803] Support Show Child Paths/Nodes in Node Management
Posted by GitBox <gi...@apache.org>.
yifuzhou commented on PR #5823:
URL: https://github.com/apache/iotdb/pull/5823#issuecomment-1124717525
Currently this pr just supports node management below storage group. It needs some works from MPP site after discussion. Can merge this pr first and will adapt node management above storage group later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #5823: [IOTDB-2803] Support Show Child Paths/Nodes in Node Management
Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on code in PR #5823:
URL: https://github.com/apache/iotdb/pull/5823#discussion_r867875965
##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/planner/plan/node/metedata/read/ChildPathsSchemaScanNode.java:
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.mpp.plan.planner.plan.node.metedata.read;
+
+import org.apache.iotdb.commons.exception.IllegalPathException;
+import org.apache.iotdb.commons.path.PartialPath;
+import org.apache.iotdb.db.mpp.common.header.HeaderConstant;
+import org.apache.iotdb.db.mpp.plan.planner.plan.node.PlanNode;
+import org.apache.iotdb.db.mpp.plan.planner.plan.node.PlanNodeId;
+import org.apache.iotdb.db.mpp.plan.planner.plan.node.PlanNodeType;
+import org.apache.iotdb.tsfile.utils.ReadWriteIOUtils;
+
+import java.nio.ByteBuffer;
+import java.util.List;
+import java.util.Objects;
+
+public class ChildPathsSchemaScanNode extends SchemaQueryScanNode {
+ // the path could be a prefix path with wildcard
+ private PartialPath prefixPath;
+
+ public ChildPathsSchemaScanNode(PlanNodeId id, PartialPath prefixPath) {
+ super(id);
+ this.prefixPath = prefixPath;
+ }
+
+ public PartialPath getPrefixPath() {
+ return prefixPath;
+ }
+
+ @Override
+ public PlanNode clone() {
+ return new ChildPathsSchemaScanNode(getPlanNodeId(), prefixPath);
+ }
+
+ @Override
+ public List<String> getOutputColumnNames() {
+ return HeaderConstant.showChildPathsHeader.getRespColumns();
+ }
+
+ @Override
+ protected void serializeAttributes(ByteBuffer byteBuffer) {
+ PlanNodeType.CHILD_PATHS_SCAN.serialize(byteBuffer);
+ ReadWriteIOUtils.write(prefixPath.getFullPath(), byteBuffer);
+ }
+
+ public static PlanNode deserialize(ByteBuffer buffer) {
+ String fullPath = ReadWriteIOUtils.readString(buffer);
+ PartialPath path;
+ try {
+ path = new PartialPath(fullPath);
+ } catch (IllegalPathException e) {
+ throw new IllegalArgumentException("Cannot deserialize ChildPathScanNode", e);
+ }
Review Comment:
We can use the serialize method in PartialPath and deserialize method in PathDeserializeUtil, which can avoid the exception try-catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org