You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/03/13 15:02:01 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request, #10534: JavaDoc input should contain delombok output and fix javadoc not executed in CI
kezhenxu94 opened a new pull request, #10534:
URL: https://github.com/apache/skywalking/pull/10534
mvn install doesn’t include the javadoc goal so the CI didn’t find the problem introduced in #10532, which changed the delombok output but didn’t change the javadoc input accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #10534: JavaDoc input should contain delombok output and fix javadoc not executed in CI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #10534:
URL: https://github.com/apache/skywalking/pull/10534#issuecomment-1466925728
> > CI / Check JavaDoc (pull_request)
>
> Oops, this still doesn't work.
turns out that `javadoc:javadoc' goal must be run after a maven install(otherwise it failed to find submodule dependencies), we cannot separate it in an individual job, so I explicitly add `javadoc` goal to the `package` job right after the install goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on pull request #10534: JavaDoc input should contain delombok output and fix javadoc not executed in CI
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #10534:
URL: https://github.com/apache/skywalking/pull/10534#issuecomment-1467104171
And the following line should have prevented the delombok’ed sources being added as source codes in maven, not sure whether it’s the IDE automatically adds the `generated-sources` as source codes or not. Anyway it’s a good idea to put the delombok’ed codes in a different folder than those protobuf codes that we expect to be added as source codes.
https://github.com/apache/skywalking/blob/c74d21c96fee0c830ef6f4e27b6f59fb61aafc70/pom.xml#L491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #10534: JavaDoc input should contain delombok output and fix javadoc not executed in CI
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #10534:
URL: https://github.com/apache/skywalking/pull/10534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10534: JavaDoc input should contain delombok output and fix javadoc not executed in CI
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10534:
URL: https://github.com/apache/skywalking/pull/10534#discussion_r1134134577
##########
pom.xml:
##########
@@ -513,7 +515,7 @@
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<sourcepath>
- ${project.build.directory}/generated-sources/delombok;
+ ${delombok.output.dir};
Review Comment:
This looks like revert the previous change, which could lead IDE reports errors again. Have you tested it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10534: JavaDoc input should contain delombok output and fix javadoc not executed in CI
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10534:
URL: https://github.com/apache/skywalking/pull/10534#issuecomment-1466325829
> CI / Check JavaDoc (pull_request)
Oops, this still doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org