You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2011/10/10 19:50:43 UTC
svn commit: r1181096 - in /trafficserver/traffic/trunk: CHANGES
mgmt/api/remote/NetworkUtilsRemote.cc mgmt/cli/TrafficLine.cc
Author: zwoop
Date: Mon Oct 10 17:50:43 2011
New Revision: 1181096
URL: http://svn.apache.org/viewvc?rev=1181096&view=rev
Log:
TS-830 Better error when there are e.g. CLI permission problems. Author: AdunGaos
Modified:
trafficserver/traffic/trunk/CHANGES
trafficserver/traffic/trunk/mgmt/api/remote/NetworkUtilsRemote.cc
trafficserver/traffic/trunk/mgmt/cli/TrafficLine.cc
Modified: trafficserver/traffic/trunk/CHANGES
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/CHANGES?rev=1181096&r1=1181095&r2=1181096&view=diff
==============================================================================
--- trafficserver/traffic/trunk/CHANGES (original)
+++ trafficserver/traffic/trunk/CHANGES Mon Oct 10 17:50:43 2011
@@ -3,6 +3,9 @@ Changes with Apache Traffic Server 3.1.1
*) [TS-932] Fix m_pending_event == NULL crash in LogCollationClientSM.cc
Author: weijin
+ *) [TS-830] Better error when there are CLI permission problems, or
+ other problems preventing operation. Author: AdunGaos.
+
*) [TS-979] Found a few places where we can segfault with strlcpy.
*) [TS-938] Fix VIA to avoid loopback address.
Modified: trafficserver/traffic/trunk/mgmt/api/remote/NetworkUtilsRemote.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/mgmt/api/remote/NetworkUtilsRemote.cc?rev=1181096&r1=1181095&r2=1181096&view=diff
==============================================================================
--- trafficserver/traffic/trunk/mgmt/api/remote/NetworkUtilsRemote.cc (original)
+++ trafficserver/traffic/trunk/mgmt/api/remote/NetworkUtilsRemote.cc Mon Oct 10 17:50:43 2011
@@ -166,7 +166,7 @@ ts_connect()
#endif
// connect call
if (connect(main_socket_fd, (struct sockaddr *) &client_sock, sockaddr_len) < 0) {
- //fprintf(stderr, "[connect] ERROR (main_socket_fd %d): %s\n", main_socket_fd, strerror(int(errno)));
+ fprintf(stderr, "[connect] ERROR (main_socket_fd %d): %s\n", main_socket_fd, strerror(int(errno)));
close(main_socket_fd);
main_socket_fd = -1;
goto ERROR; //connection is down
Modified: trafficserver/traffic/trunk/mgmt/cli/TrafficLine.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/mgmt/cli/TrafficLine.cc?rev=1181096&r1=1181095&r2=1181096&view=diff
==============================================================================
--- trafficserver/traffic/trunk/mgmt/cli/TrafficLine.cc (original)
+++ trafficserver/traffic/trunk/mgmt/cli/TrafficLine.cc Mon Oct 10 17:50:43 2011
@@ -80,7 +80,7 @@ handleArgInvocation()
TSRecordEle *rec_ele = TSRecordEleCreate();
if ((err = TSRecordGet(ReadVar, rec_ele)) != TS_ERR_OKAY) {
- fprintf(stderr, "%s: Variable Not Found\n", programName);
+ fprintf(stderr, "%s: %s\n", programName, TSGetErrorMessage(err));
} else {
switch (rec_ele->rec_type) {
case TS_REC_INT: