You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "joao-r-reis (via GitHub)" <gi...@apache.org> on 2025/08/26 16:12:16 UTC
[PR] CASSGO-88 Do not set beta protocol flag when using v5 [cassandra-gocql-driver]
joao-r-reis opened a new pull request, #1906:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1906
Driver was automatically setting beta flag when using v5 protocol which causes issues when trying to connect to Cassandra versions that supported beta v5 like 3.11.
Patch by João Reis; reviewed by TBD for CASSGO-88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-88 Do not set beta protocol flag when using v5 [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis merged PR #1906:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-88 Do not set beta protocol flag when using v5 [cassandra-gocql-driver]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #1906:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1906#discussion_r2325095391
##########
conn.go:
##########
@@ -1317,7 +1317,24 @@ func (c *Conn) execInternal(ctx context.Context, req frameBuilder, tracer Tracer
defer c.releaseStream(call)
if v := resp.framer.header.version.version(); v != c.version {
- return nil, NewErrProtocol("unexpected protocol version in response: got %d expected %d", v, c.version)
+ errProtocol := NewErrProtocol("unexpected protocol version in response: got %d expected %d", v, c.version)
+ responseFrame, err := resp.framer.parseFrame()
+ if err != nil {
+ c.logger.Warning("Framer error while attempting to parse potential protocol error.",
+ newLogFieldError("err", err))
+ return nil, errProtocol
+ }
+ //goland:noinspection GoTypeAssertionOnErrors
+ errFrame, isErrFrame := responseFrame.(errorFrame)
+ if !isErrFrame {
Review Comment:
NIT: How about merging two below conditions together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSGO-88 Do not set beta protocol flag when using v5 [cassandra-gocql-driver]
Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1906:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1906#discussion_r2379407459
##########
conn.go:
##########
@@ -1317,7 +1317,24 @@ func (c *Conn) execInternal(ctx context.Context, req frameBuilder, tracer Tracer
defer c.releaseStream(call)
if v := resp.framer.header.version.version(); v != c.version {
- return nil, NewErrProtocol("unexpected protocol version in response: got %d expected %d", v, c.version)
+ errProtocol := NewErrProtocol("unexpected protocol version in response: got %d expected %d", v, c.version)
+ responseFrame, err := resp.framer.parseFrame()
+ if err != nil {
+ c.logger.Warning("Framer error while attempting to parse potential protocol error.",
+ newLogFieldError("err", err))
+ return nil, errProtocol
+ }
+ //goland:noinspection GoTypeAssertionOnErrors
+ errFrame, isErrFrame := responseFrame.(errorFrame)
+ if !isErrFrame {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org