You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/12/10 15:50:19 UTC

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23772


Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................

IMPALA-14606: (addendum) Install Python 3 for RHEL8

The first IMPALA-14606 commit miss to setup Python 3 in fresh RHEL8
machine. This was not caught before because I test using downstream
jenkins and it reuse RHEL8 machine that previously setup with Python 2.

This patch fix the issue by skipping pip install argparse that broke the
script and run setup_python3 instead for RHEL8 machine.

Testing:
- Run full bootstrap_system.sh and buildall.sh in fresh RHEL8 machine.

Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
---
M bin/bootstrap_system.sh
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/23772/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................

IMPALA-14606: (addendum) Install Python 3 for RHEL8

The first IMPALA-14606 commit miss to setup Python 3 in fresh RHEL8
machine. This was not caught before because I test using downstream
jenkins and it reuse RHEL8 machine that previously setup with Python 2.

This patch fix the issue by skipping pip install argparse that broke the
script and run setup_python3 instead for RHEL8 machine.

Testing:
- Run full bootstrap_system.sh and buildall.sh in fresh RHEL8 machine.

Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Reviewed-on: http://gerrit.cloudera.org:8080/23772
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Riza Suminto <ri...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Laszlo Gaal: Looks good to me, approved
  Riza Suminto: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 16:44:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1: Verified+1

Merging it right away since we don't test against RHEL8 upstream.


-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 17:22:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/21126/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 16:16:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

> Patch Set 1:
> 
> (1 comment)

Ship it.

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh@349
PS1, Line 349: # redhat8 setup_python2
> I plan to do it separately as https://issues.apache.org/jira/browse/IMPALA-
SGTM



-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 17:21:10 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh@349
PS1, Line 349: # redhat8 setup_python2
Wouldn't it be better just to remove these lines instead of commenting them out?



-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 17:17:38 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh@350
PS1, Line 350: # redhat8 pip install --user argparse
> argparse doesn't need to be installed separately for python3 then?
No it does not. It becomes standard in Python 3.



-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 16:41:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh@350
PS1, Line 350: # redhat8 pip install --user argparse
argparse doesn't need to be installed separately for python3 then?



-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 16:15:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14606: (addendum) Install Python 3 for RHEL8

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23772 )

Change subject: IMPALA-14606: (addendum) Install Python 3 for RHEL8
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/23772/1/bin/bootstrap_system.sh@349
PS1, Line 349: # redhat8 setup_python2
> Wouldn't it be better just to remove these lines instead of commenting them
I plan to do it separately as https://issues.apache.org/jira/browse/IMPALA-14620
It will cover much more removal.



-- 
To view, visit http://gerrit.cloudera.org:8080/23772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6df0a534175404fe96d32eeb1e7bf0aa9ca204cd
Gerrit-Change-Number: 23772
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 17:19:55 +0000
Gerrit-HasComments: Yes