[GitHub] [airflow] ashb commented on a change in pull request #20349: Fix Scheduler crash when executing task instances of missing DAG

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #20349:
URL: https://github.com/apache/airflow/pull/20349#discussion_r770949995



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -402,6 +402,14 @@ def _executable_task_instances_to_queued(self, max_tis: int, session: Session =
                     # Many dags don't have a task_concurrency, so where we can avoid loading the full
                     # serialized DAG the better.
                     serialized_dag = self.dagbag.get_dag(dag_id, session=session)
+                    # If the dag is missing, continue to the next task.
+                    if not serialized_dag:
+                        self.log.error(
+                            "DAG '%s' for taskinstance %s not found in serialized_dag table",
+                            dag_id,
+                            task_instance,
+                        )
+                        continue

Review comment:
       If we can't find them, shouldn't these be set to failed or something, otherwise these TIs will always come up each time around the loop




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org