[jira] [Commented] (NIFI-2169) Improve RouteText performance with pre-compilation of RegEx in certain cases

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291828#comment-16291828 ] 

ASF GitHub Bot commented on NIFI-2169:
--------------------------------------

GitHub user mgaido91 opened a pull request:

    https://github.com/apache/nifi/pull/2343

    NIFI-2169: Cache compiled regexp for RouteText

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? N/A
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? N/A
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? N/A
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? N/A
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? N/A
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/nifi NIFI-2169

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2343
    
----
commit f6b9aab6775f62863071321618bfa151e3b34c97
Author: Marco Gaido <mg...@hortonworks.com>
Date:   2017-12-14T23:44:32Z

    NIFI-2169: Cache compiled regexp for RouteText

----


> Improve RouteText performance with pre-compilation of RegEx in certain cases
> ----------------------------------------------------------------------------
>
>                 Key: NIFI-2169
>                 URL: https://issues.apache.org/jira/browse/NIFI-2169
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 0.6.1
>            Reporter: Stephane Maarek
>            Assignee: Oleg Zhurakousky
>              Labels: beginner, easy
>
> When using RegEx matches for the RouteText processor (and possibly other processors), the RegEx gets recompiled every time the processor works. The RegEx could be precompiled / cached under certain conditions, in order to improve the performance of the processor
> See email from Mark Payne:
> Re #2: The regular expression is compiled every time. This is done, though, because the Regex allows the Expression
> Language to be used, so the Regex could actually be different for each FlowFile. That being said, it could certainly be
> improved by either (a) pre-compiling in the case that no Expression Language is used and/or (b) cache up to say 10
> Regex'es once they are compiled. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)