[GitHub] [beam] AydarZaynutdinov edited a comment on pull request #14856: [BEAM-11873] Add support for writes with returning values in JdbcIO

[GitBox <gi...@apache.org>]

AydarZaynutdinov edited a comment on pull request #14856:
URL: https://github.com/apache/beam/pull/14856#issuecomment-907130750


   Thanks @aromanenko-dev, @aaltay. As I understood I should:
   - rename method withReturningResults() to withWriteResults().
   - keep old method with name withResults() (do not rename it to withVoidResults).
   - change back private to public access for writeVoid method.
   
   About other discussions:
   - records by batches. Seems like Vitaliy explained why there is an execute() method instead of executeBatch(). So I guess I should leave it like it is now -> use execute(). Is it right?
   -  wrap up `V`. I'm not sure that we need this wraping, because a new abstract class JdbcWriteResult will have no any rules or parameters and as a result it would be just an empty class. Maybe it would be better to transform JdbcWriteResult to empty interface? So it would be like a marker for each`V`. Could you please share your thoughts?
   
   Is there anything else I should address?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org