You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/26 16:41:00 UTC

[GitHub] [incubator-superset] bkyryliuk commented on pull request #10165: fix: downgrade sqlparse and add unit test

bkyryliuk commented on pull request #10165:
URL: https://github.com/apache/incubator-superset/pull/10165#issuecomment-650278210


   @villebro addressed the comments, thanks!
   @john-bodley 0.36 version used sqlparse 0.3.0 as I remember,
   https://sqlparse.readthedocs.io/en/latest/changes/ - shows some bugfixes and improvements, however I am not familiar on how they related to superset bugs. https://github.com/apache/incubator-superset/pull/9786/files doesn't seem to be mentioned in any superset issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org