You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/30 18:13:00 UTC
[jira] [Commented] (CALCITE-2073) Allow disabling of protobuf
generation
[ https://issues.apache.org/jira/browse/CALCITE-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273097#comment-16273097 ]
ASF GitHub Bot commented on CALCITE-2073:
-----------------------------------------
GitHub user joshelser opened a pull request:
https://github.com/apache/calcite-avatica/pull/19
CALCITE-2073 Allow disabling of the maven-protobuf-plugin
Protobuf compilation will still run by default, but users can disable it by providing `-P!compile-protobuf`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshelser/calcite-avatica 2073-protobuf-gen-disable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit be2d056bbfc588a595a9ca1f5f5b62dfdff5d415
Author: Josh Elser <el...@apache.org>
Date: 2017-11-30T18:11:15Z
[CALCITE-2073] Allow disabling of the maven-protobuf-plugin
----
> Allow disabling of protobuf generation
> --------------------------------------
>
> Key: CALCITE-2073
> URL: https://issues.apache.org/jira/browse/CALCITE-2073
> Project: Calcite
> Issue Type: Task
> Components: avatica
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Trivial
> Fix For: avatica-1.11.0
>
>
> The xolstice maven-protobuf-plugin has a runtime dependency on a specific glibc version which fails on older OS versions (notably Centos6).
> For most builds, it's unnecessary to regenerate the protobuf "specs" into Java code. We can add an option for individuals to disable this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)