You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/02 11:25:32 UTC

[GitHub] [ozone] smitajoshi12 opened a new pull request, #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

smitajoshi12 opened a new pull request, #3929:
URL: https://github.com/apache/ozone/pull/3929

   What changes were proposed in this pull request?
   After Clicking Button IT should trigger om Sync and disable button show message in tool tip.
   
   What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-7245
   
   ## How was this patch tested?
   Manually
   
   ![image](https://user-images.githubusercontent.com/112169209/199478021-e9d87539-1dee-4cd0-af67-1927ee09cd79.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3929:
URL: https://github.com/apache/ozone/pull/3929#discussion_r1013296019


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -49,9 +51,12 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
         >
           {moment(lastRefreshed).format('LT')}
         </Tooltip>
-      );
-
-      const omDBDeltaFullToolTip = <span>
+       );
+    
+     const omSyncStatusDisplay = omStatus === '' ? '' : omStatus ? <div>OM DB update is successfully triggered.</div> : <div>OM DB update is already running.</div>;

Review Comment:
   ohh i see, thanks!!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] dombizita commented on pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
dombizita commented on PR #3929:
URL: https://github.com/apache/ozone/pull/3929#issuecomment-1308484357

   > Users of the Recon are not developers, and they might don't know what OM DB is. Maybe something like "Cluster sync"?
   
   Hi @myskov, thanks for the review. Recon also maintains a DB for SCM which later can be added here as well. This is why we decided to differentiate these two syncs and name it OM DB sync (also we only trigger a sync between OM and Recon with the button, so other cluster related informations won't get refreshed by this). I think "Cluster sync" could be misleading, but I am open to other names. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
smitajoshi12 commented on code in PR #3929:
URL: https://github.com/apache/ozone/pull/3929#discussion_r1012553756


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -49,9 +51,12 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
         >
           {moment(lastRefreshed).format('LT')}
         </Tooltip>
-      );
-
-      const omDBDeltaFullToolTip = <span>
+       );
+    
+     const omSyncStatusDisplay = omStatus === '' ? '' : omStatus ? <div>OM DB update is successfully triggered.</div> : <div>OM DB update is already running.</div>;

Review Comment:
   omStatus may contain three values  Empty space when we are not clicking to button and true and false depending upon  END Point Response.
   
   sync trigger endpoint returns false: update button tooltip can show "OM DB update is already running", and becomes gray and unclickable
   sync trigger endpoint returns true: update button tooltip can show "OM DB update is successfully triggered", also becomes gray and unclickable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3929:
URL: https://github.com/apache/ozone/pull/3929#discussion_r1012246832


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/components/autoReloadPanel/autoReloadPanel.tsx:
##########
@@ -49,9 +51,12 @@ class AutoReloadPanel extends React.Component<IAutoReloadPanelProps> {
         >
           {moment(lastRefreshed).format('LT')}
         </Tooltip>
-      );
-
-      const omDBDeltaFullToolTip = <span>
+       );
+    
+     const omSyncStatusDisplay = omStatus === '' ? '' : omStatus ? <div>OM DB update is successfully triggered.</div> : <div>OM DB update is already running.</div>;

Review Comment:
   does the second _omStatus_ variable check if the string is true or false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3929:
URL: https://github.com/apache/ozone/pull/3929#issuecomment-1319372781

   Thanks @smitajoshi12 for the patch, @DaveTeng0 for the review.
   
   @dombizita and @myskov we can continue the discussion in the follow-up jira HDDS-7505.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] myskov commented on pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
myskov commented on PR #3929:
URL: https://github.com/apache/ozone/pull/3929#issuecomment-1302096364

   Users of the Recon are not developers, and they might don't know what `OM DB` is. Maybe something like "Cluster sync"?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3929:
URL: https://github.com/apache/ozone/pull/3929#issuecomment-1314249158

   @smitajoshi12 Would you resolve the merge conflict in `autoReloadPanel.tsx`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl merged pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
smengcl merged PR #3929:
URL: https://github.com/apache/ozone/pull/3929


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] smengcl commented on pull request #3929: HDDS-7245. Recon: Add button to trigger OM DB Sync (Frontend)

Posted by GitBox <gi...@apache.org>.
smengcl commented on PR #3929:
URL: https://github.com/apache/ozone/pull/3929#issuecomment-1314287362

   > Users of the Recon are not developers, and they might don't know what OM DB is. Maybe something like "Cluster sync"?
   
   I guess we could just call it DB sync. Because we would have SCM DB sync as well, apart from OM's. We could differentiate in the tooltip / drop down.
   
   And instead of inventing vague terms just to make it easier for regular users to understand, we should educate users. Add new tooltips like we already have in other tab's header. Let me know what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org