[GitHub] [helix] junkaixue commented on a change in pull request #1988: Implement deactivate rest API

[GitBox <gi...@apache.org>]

junkaixue commented on a change in pull request #1988:
URL: https://github.com/apache/helix/pull/1988#discussion_r829611141



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
##########
@@ -243,6 +243,18 @@ public Response updateCluster(@PathParam("clusterId") String clusterId,
         }
         break;
 
+      case deactivate:
+        if (superCluster == null) {
+          return badRequest("Super Cluster name is missing!");
+        }
+        try {
+          clusterSetup.activateCluster(clusterId, superCluster, false);
+        } catch (Exception ex) {
+          LOG.error("Failed to deactivate cluster {} from super cluster {}.", clusterId, superCluster);
+          return serverError(ex);

Review comment:
       Let's not use server error. It means Helix REST service has issue. But this is actually there is no super cluster. It should be invalid request or something.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org