You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/08/01 06:43:35 UTC

[jira] [Commented] (HBASE-6473) deletedtable is not deleted completely, some region may be still online

    [ https://issues.apache.org/jira/browse/HBASE-6473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426325#comment-13426325 ] 

Hadoop QA commented on HBASE-6473:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12538326/HBASE-6473-trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

    -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2468//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2468//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2468//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2468//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2468//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2468//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2468//console

This message is automatically generated.
                
> deletedtable is not deleted completely, some region may be still online
> -----------------------------------------------------------------------
>
>                 Key: HBASE-6473
>                 URL: https://issues.apache.org/jira/browse/HBASE-6473
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0
>            Reporter: zhou wenjian
>             Fix For: 0.96.0, 0.94.2
>
>         Attachments: HBASE-6473-trunk.patch
>
>
> consider such Scenario:
> we have a table called T1, which has 1 regions: A 
> 1. move A from rs1 to rs2,and A is now closed
> 2. disable T1,
> 3. delete  T1.
> when we disable T1, disable handler will just set the zk to disabled and A will still be assigned. when Ais opened, A in transition will be clean out. 
> At that time, Deletetable found it is safe to delete all regions and table in meta and fs , it will also delete the zk node of T1.
> {code}
> while (System.currentTimeMillis() < done) {
>         AssignmentManager.RegionState rs = am.isRegionInTransition(region);
>         if (rs == null) break;
>         Threads.sleep(waitingTimeForEvents);
>         LOG.debug("Waiting on  region to clear regions in transition; " + rs);
>       }
>       if (am.isRegionInTransition(region) != null) {
>         throw new IOException("Waited hbase.master.wait.on.region (" +
>           waitTime + "ms) for region to leave region " +
>           region.getRegionNameAsString() + " in transitions");
>       }
> {code}
> however A is still being unassigned, when it finished closed the A,it finds that the disabled state in zk is deleted, and then A will be assigned again.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira